[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/xl: fix vif and vcpupin parse tests


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Fri, 8 Apr 2022 17:05:51 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 08 Apr 2022 16:06:23 +0000
  • Ironport-data: A9a23:TXhMAqkclAyX33xhOKCYDh3o5gzoJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIXDW+GP/aLZmujKth+YITg/BgAvpKDzNFqQVFr+CA1HiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlW1PV4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYQloiO/X+trohWDJ6Mxx9N6JPu4bZLi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY uJHOWAwMEWbOnWjPH8nJrIbkOaCiEDHYhxqoVOemqY452bMmVkZPL/Fb4OOJ43iqd9utlmcj nLL+SL+GB5yHMySz3+J/2yhgsfLnDjnQ8QCGbug7PlojVaPgGsJB3UruUCT+KfjzBTkApQGd hJSqnFGQbUOGFKDRYT2WkWKjiC4tTU+e+dTGeIzqziTxf+Bi+qGPVQsQjlEYd0gkcY5Qz02y 1OE9+/U6SxTXK69EizEqOrNxd+mEW1MdDJZO3dYJecQy4O7yLzfmC4jWTqK/ESdqtTuUQ/9z DmRxMTVr+VC1JVbv0lXEL2uvt5NmnQrZlNtjuk0djj8hu+cWGJDT9b1gbQ8xawdRLt1tnHb4 BA5dzG2tYji962lmi2XW/kqF7q0/fuDOzC0qQcxQ8h7p2nwqyH8JNk4DNRCyKFBaJtsldjBO hG7hO+szMULYCvCgVFfPepd9PjGPYC/TI+4B5g4n/JFY4RrdR/vwc2dTRX44owZq2B1yftXE c7CKa6EVC9GYYw6nGveb7pMitcDm3FhrV4/sLimlnxLJ5LFPyXLIVrEWXPTBt0EAFSs/F2Oo 4kCbZPTo/idOcWnChTqHUcoBQhiBRAG6Vre9KS7qsbrztJaJVwc
  • Ironport-hdrordr: A9a23:0YeH4KOQjj4Yv8BcTgujsMiBIKoaSvp037BL7TEVdfUxSKGlfq +V88jzuSWbtN9pYgBFpTnYAtjmfZq+z+8W3WByB9uftWDd0QPDEGgF1+rfKlXbcBEWndQttp uIHZIfNDUlZWIK9PoT/2GDYqgdKMjuytHPuQ/Bp00dNT2CYZsQkDuRcjzraXGfGWF9dOAE/I L13Ls7m9K6EU5nEviGOg==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Apr 08, 2022 at 03:31:46PM +0200, Roger Pau Monne wrote:
> Current vif and vcpupin parse tests are out of sync.  First of all, xl
> returns 1 on failure, so replace the expected error code.
> 
> Secondly fix the expected output from some vif tests, as xl will no
> longer print the unpopulated fields.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

> ---
> We should find a way for those tests to be run as part of osstest, or
> else they will go stale again sooner or later.

I guess having those two tests case in "tools/tests/" would be better,
then having osstest runs all tests in "tools/tests/" might be the way to
go.

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.