[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] vPCI: fix MSI-X PBA read/write gprintk()s
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 7 Apr 2022 17:01:11 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F4Fy+HuQ1ahLRZkkeLjYi3ElgU7JhahZPR2UkCBKzmg=; b=SIM8bWJAANGywSUWLnPNqrqvRUpl5H0E+xP9LDE3lLMKy7ITzum804E+V5O9bYMB1UBQX+KBBkGyolLaCviUTRD4wT4ymFhr2CmuUA+zwsY+hyaaK8rhc0v7/cn7veO8P3zpyFJW3FSXortlKUsGDQioe49PWdoDXGxLtSWSHpDgT4Q+Iw9QTTOtWFAf5y5gc2536n3WoKyaRShiGZWgrrdroYhaEE7z2GqyjZExYt2eoht36rjYsyLiEi3YN7xHzn2vqRnRGeghu0KUkGFe0mEkSABcMklbt+7GY8KVDiy/3LZAWJbYfJOu5EaAiYcfBxIaH/XklpSbb+VS4B6oIg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vc/WwV4fq5NMpC7EaUqRWUmkKEla2Y89CH6g6ajz0b/bHsumcqwmBI9Ql6bJmB+4wl24DWKa0adWogLVuKsuRDuNE+mKjwVsB3V/2Gv/QIreB76KlwQhlA2kOAM35DSJbTPpdcHCQddMvu0oW9egjZrJBxsjs/VZ7CPLs+H6VxzPF1lCscY4ipj0j4i4b9DkaFcCv2vjXOw4zQT3MZx5IenES0wYg2irYONuVC9mQYjOu77eM2nVScmH+vUkpd22MfeGYZk9ObfHV5+P3fnKqH9Mwcgpfg5wVwivKDImycHaGe+JqwU4iINWSTb/MQTx2aydHfr4BxseGCKg50K0rw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 07 Apr 2022 15:01:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
%pp wants the address of an SBDF, not that of a PCI device.
Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
I can't resist to say that this would not have happened if we hadn't
made this a %p extension, but e.g. a %o one as I had proposed.
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -247,7 +247,7 @@ static int cf_check msix_read(
{
gprintk(XENLOG_WARNING,
"%pp: unable to map MSI-X PBA, report all pending\n",
- msix->pdev);
+ &msix->pdev->sbdf);
return X86EMUL_OKAY;
}
@@ -332,7 +332,7 @@ static int cf_check msix_write(
/* Unable to map the PBA, ignore write. */
gprintk(XENLOG_WARNING,
"%pp: unable to map MSI-X PBA, write ignored\n",
- msix->pdev);
+ &msix->pdev->sbdf);
return X86EMUL_OKAY;
}
|
