[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0.9/2] VT-d: don't needlessly look up DID


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Thu, 7 Apr 2022 11:40:56 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bq9sl9b0QstNOmyN2kU3r7P4OKgqjlnWCRO0YZS0w+Y=; b=QRTKE0/w8/ltfKSr7gQqN0TJuntm0WfZ8DmhzBcZvoa061QFpcYxKA42PgghRp+ftwbQae6CWmEiYugsqXcn5sofYkWamKiF5KC0rnyVHZBjyMApHjCgt5PTpZ4bvbfHgbzV9GCnqVnvDLYKpj9ZiS/oyb0t9JRAG5KREl7n2unBZC+KeR915bFIMfv1PmfyanIpZpmzZJUxvc530YWKREhdE80AtxuEnjhloxS2uKDuJFpJeLKNnfLg0yGwhk0OFKgNDfHcQ9v5VXqZMTix9An7gzOH8hiU0NOcmy3R5d4eof3gAh+ZikkJHxYOQd7Z02pgLiLjCpLW5e7AOsR54w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QX5wNIUbwP+imZYiGeT0g1+7Jz3Y0zjorFZOKlET0r6SNmGDwdWhGhfgP1XP8aeRzfvxXeQIs5w+ifvPjwXv7qWSWbLRWkHPZfS87EwzK9Oxle3yMC7lzKirFXEeeg5bnCkotYDbIilO6A6TkkZMzGO9q0LWYB5/Lw9tkmcn8nd+3lfDA5br4zU5/BorxGIX+X/6NsPurluEsO0eWa9VDYDWGXW97VyP2qpJ+SdzZ+GEe3tI+dZNWuqFiXjW1UAQliTvgX7BO5/yUhw4orQpCo6BpiP+q2JwiMBoSsFLRwJFikGtYns8OghaRCeuqvTfCZDdEnfwt4zKV0VuTlCSZw==
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Thu, 07 Apr 2022 09:41:23 +0000
  • Ironport-data: A9a23:Ktl9r62JllocnUY+J/bD5f9xkn2cJEfYwER7XKvMYLTBsI5bp2ACn GUaC2rSMv3cMWume90gOoSxpkhQuZDUzt5jT1E+pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tIw3oDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /0Oi5eTUlooYZfQv7g/fRVWFX9hELVJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u1pkSRa+EP qL1bxJBRg3uOS12IGwwN78Uk/+u2lzjWBlx/Qf9Sa0fvDGIkV0ZPKLWGNnYZN2MA9lUl0Cwp 2Ta8mC/CRYfXPSHwCeB2mKhgKnIhyyTcIAYGaC89/VqqEaO3WFVAxoTPXOrrP/8hkOgVtZ3L 00P5jFovaU07FasTNT2Q1u/unHsg/IHc4MOSatgsljLk/eKpVbCboQZctJfQJ8Yv+wtGD117 EOuw/HHCTJp7qK4UX3Io994sgiOESQSKGYDYwoNQg0E/8TvrekPs/7fcjpwOPXr14OoQFkc1 xjP9XFj3OtL0abnwo3hpTj6bySQSo8lp+LfziHeRSqb4wxwf+ZJjKT4uAGAvZ6swGt0J2RtX UToeeDDtIji7rnXzURhpdnh+pnzup5p1xWG3DZS82EJrWjFxpJaVdk4DMtCDEloKN0YXjTif VXevwhcjLcKYif7N/8qPtLuVJ1zpUQFKTgDfqqJBjapSsIvHDJrAQk0PRLAt4wTuBZEfV4D1 WezLp/3UCdy5VVPxzuqXeYNuYLHNQhlrV4/savTlkz9uZLHPSb9Ye5cbDOmM7BohIvZ8V692 4sOaKO3J+B3DbSWjt//qtVIczjn7BETWPjLliCgXrLbeVo5RTt5Upc8A9oJIuRYokicrc+Rl lmVUU5E0lvvw3rBLASBcHd4b73zG514qBoG0eYEZD5EB1BLjV6T0Zoi
  • Ironport-hdrordr: A9a23:rhuULqOJMUSARMBcT1j155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjztSWUtN4QMEtQ/uxoHJPwO080kqQFnLX5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79 YdT0EcMqyAMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt9dBmxCe2Cm+yNNNW177c1TLu vi2iMLnUvqRZxRBf7Lc0UtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF K13jDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2u XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LrEbQN/L/AEqZNScxPf5UZllsp7yr h302WQsIcSJQ/cnQzmjuK4GS1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+ NjZfusq8q+SWnqL0wxg1Mfg+BFBh8Ib1W7qwk5y4CoOgFt7TFEJxBy/r1bop8CnKhNPKWsqd 60dpiAr4s+PfP+XZgNdNvpfvHHeFAlYSi8eV56cm6XXJ3uBRr22urKCfMOlaaXRKA=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Apr 07, 2022 at 11:27:53AM +0200, Jan Beulich wrote:
> If get_iommu_domid() in domain_context_unmap_one() fails, we better
> wouldn't clear the context entry in the first place, as we're then unable
> to issue the corresponding flush. However, we have no need to look up the
> DID in the first place: What needs flushing is very specifically the DID
> that was in the context entry before our clearing of it.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.