[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD



On 4/6/22 2:05 PM, Christoph Hellwig wrote:
Secure erase is a very different operation from discard in that it is
a data integrity operation vs hint.  Fully split the limits and helper
infrastructure to make the separation more clear.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

For the bcache part,

Acked-by: Coly Li <colyli@xxxxxxx>


Thanks.

Coly Li


---
  block/blk-core.c                    |  2 +-
  block/blk-lib.c                     | 64 ++++++++++++++++++++---------
  block/blk-mq-debugfs.c              |  1 -
  block/blk-settings.c                | 16 +++++++-
  block/fops.c                        |  2 +-
  block/ioctl.c                       | 43 +++++++++++++++----
  drivers/block/drbd/drbd_receiver.c  |  5 ++-
  drivers/block/rnbd/rnbd-clt.c       |  4 +-
  drivers/block/rnbd/rnbd-srv-dev.h   |  2 +-
  drivers/block/xen-blkback/blkback.c | 15 +++----
  drivers/block/xen-blkback/xenbus.c  |  5 +--
  drivers/block/xen-blkfront.c        |  5 ++-
  drivers/md/bcache/alloc.c           |  2 +-
  drivers/md/dm-table.c               |  8 ++--
  drivers/md/dm-thin.c                |  4 +-
  drivers/md/md.c                     |  2 +-
  drivers/md/raid5-cache.c            |  6 +--
  drivers/mmc/core/queue.c            |  2 +-
  drivers/nvme/target/io-cmd-bdev.c   |  2 +-
  drivers/target/target_core_file.c   |  2 +-
  drivers/target/target_core_iblock.c |  2 +-
  fs/btrfs/extent-tree.c              |  4 +-
  fs/ext4/mballoc.c                   |  2 +-
  fs/f2fs/file.c                      | 16 ++++----
  fs/f2fs/segment.c                   |  2 +-
  fs/jbd2/journal.c                   |  2 +-
  fs/nilfs2/sufile.c                  |  4 +-
  fs/nilfs2/the_nilfs.c               |  4 +-
  fs/ntfs3/super.c                    |  2 +-
  fs/xfs/xfs_discard.c                |  2 +-
  fs/xfs/xfs_log_cil.c                |  2 +-
  include/linux/blkdev.h              | 27 +++++++-----
  mm/swapfile.c                       |  6 +--
  33 files changed, 168 insertions(+), 99 deletions(-)
[snipped]
diff --git a/drivers/md/bcache/alloc.c b/drivers/md/bcache/alloc.c
index 097577ae3c471..ce13c272c3872 100644
--- a/drivers/md/bcache/alloc.c
+++ b/drivers/md/bcache/alloc.c
@@ -336,7 +336,7 @@ static int bch_allocator_thread(void *arg)
                                mutex_unlock(&ca->set->bucket_lock);
                                blkdev_issue_discard(ca->bdev,
                                        bucket_to_sector(ca->set, bucket),
-                                       ca->sb.bucket_size, GFP_KERNEL, 0);
+                                       ca->sb.bucket_size, GFP_KERNEL);
                                mutex_lock(&ca->set->bucket_lock);
                        }


[snipped]




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.