[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/8] x86/EFI: retrieve EDID
- To: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 6 Apr 2022 16:24:52 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CQMGbuSph1mdv2l3vc6SQzTY0C5EJ114cvI25l2Z4uc=; b=P5S2Sz6HauJBS2urG2VEk5PoeO9WH5qmolAWTx0HkY+QI24KsNeSTPyfWMAmyZRLairCiXeaSKC9ICqzBaRYY+4BkyhrmlLrUMJy7wl7fcsckb4YYndoVd8IzlcdyNqHOhzDZvXn+v/0KtWdK/ggJILREhmhL3SM25nblQDeUsGC4LkcIOGEtgyXlUbQ9TECcoF7quhe+KB5lezDEAtrRPYAUSV9BkWx/majSmgrJW7k5+bGlGQWSkZEQG6UZgjvKqnGQAG/7BMo9e8PdMtAty27Q2yUqMcG38hD74LGftL0444okzicCe63xAtJsFnJ1TFjRWuSkaUXbhwLcxsvuQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AtQm/pg967C2++0701emy3QnC6nkbTAyqCv/oMNBo+no3tq8Wqwaom4OkFofu3bqm4Q3eVelZlR4yynNw6dDK24AZtb+yHgKqaXBRKQSEd6EUelsswqhb42k/M7TO/B3FZGD361CavqMH+Sc+Mpqs8A5fSaBUmjFj0aauAlAsVO9tldZzrP2Cy5XGN39HWHfyrndXult8PNFZTBSZ5kDFMU5aTCiwDuZWS7kaiBTQ5za+VSHeK+hfRQZL02HsejzCgKI51SJvSPDREXQYCCRTSk/e06AOIK7GMoXFxxHI3njAhY9Y/LSeU9O0UNw94lPGHit1jjqnEkHckCcONORPQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 06 Apr 2022 14:25:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 31.03.2022 11:45, Jan Beulich wrote:
> When booting directly from EFI, obtaining this information from EFI is
> the only possible way. And even when booting with a boot loader
> interposed, it's more clean not to use legacy BIOS calls for this
> purpose. (The downside being that there are no "capabilities" that we
> can retrieve the EFI way.)
>
> To achieve this we need to propagate the handle used to obtain the
> EFI_GRAPHICS_OUTPUT_PROTOCOL instance for further obtaining an
> EFI_EDID_*_PROTOCOL instance, which has been part of the spec since 2.5.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> Setting boot_edid_caps to zero isn't desirable, but arbitrarily setting
> one or both of the two low bits also doesn't seem appropriate.
>
> GrUB also checks an "agp-internal-edid" variable. As I haven't been able
> to find any related documentation, and as GrUB being happy about the
> variable being any size (rather than at least / precisely 128 bytes),
> I didn't follow that route.
> ---
> v3: Re-base.
> v2: New.
>
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -464,6 +464,10 @@ static void __init efi_arch_edd(void)
> {
> }
>
> +static void __init efi_arch_edid(EFI_HANDLE gop_handle)
> +{
> +}
> +
> static void __init efi_arch_memory_setup(void)
> {
> }
May I ask for an Arm side ack here, please?
Thanks, Jan
|
