[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] VT-d: avoid infinite recursion on domain_context_mapping_one() error path


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 6 Apr 2022 16:03:11 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KkmkANuBOeSe67zXP4NdiqNnGLrAzAMvd1p3Tvzy/zc=; b=n7ZKajFpEQHXGuR3qGd38atssBPa/gf0Vv8hVJzuLq//kWgLv7UWOcuLLXLWuJYrWlx+VPg72O9d0JB+aB3EAZ6WXHNsRMvcpFwEV7BYg3TBl7oSlbe3T+xD3UkqnUhg4gTySSeAsxgtg04/VnNF0Zk+AY1xjOnAjTmnNstxT2lvmuIofuF/VbKGLSFxJnIwr9eT9px4a/FO5TQXQN4b9syZZPWXuF4FI32Mhj1NN4P8SKy5WL/2xaSQv7354UEJYLkg/15LtF8D5NaMwfQBWFZkCZezsFwZbomcMlNncGJ2GN2X/6QHufHgFx8GyNVosjnKben1aMMH2gSUpift1Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SVnekTLE4YCIYsQ50hF43UiqanNbROUiFGflaBgcc1FgFfWIclEv2q/F5D1C4qY2VpY5O/0dkIE/6clAoEbJQSJ/9FHN0cfrPQQLm2844gDm8z8mx6GxpXSZokxcg2tLFleozPhKA+IfOGdYmRr9HIzdn8KtwFFnETOZzr89OVoFa2KPJaA6jiP/N+QvEdkNn8//IpvqaoX8vNa1qtzxi5ot2OEVA/PWDwcl1uG39WcOqvcG6iLAJEi4s2pKDSApwhHrQCr9WQYY1x4+G5rlBqlgQ/uOUYuEgusVtO45ejGdvugNqvlWizRHTUnulRmo380dIti1hulw4QPNRrt40Q==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Kevin Tian" <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "Paul Durrant" <paul@xxxxxxx>
  • Delivery-date: Wed, 06 Apr 2022 14:04:06 +0000
  • Ironport-data: A9a23:LdiyfajgcP3Pp0u5GNQAjmW0X161TxAKZh0ujC45NGQN5FlHY01je htvXGHUM6qIYWXzeohwOYzg9kkFvMDTxtI2HgVt+3wzRS4b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1vT4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YQ4vAILeo/4vbzl3NQwnIat5+aHiAXfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiOP pdJMGs2BPjGSzdgOWgmU4gup7+52n7ccn55rAiMpJNitgA/yyQuieOwYbI5YOeiRshLn0Deu mPP+Uz4BA0XMJqUzj/t2mqlm+vnjS79HoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YSsV/XjPCOukDAWzZCHmUphMEaWNEeTDoU+ U2yheHVJRNJneSJT02c6JK0ombnUcQKFlMqaSgBRAoDxtDspoAvkx7CJupe/L6JYs7dQm+pn W3TxMQqr/BK1JNQif3nlbzSq2j0zqUlWDLZ8ek+soiNygpiLLCoaIWzgbQwxaYRdd3JJrVtU ZVtpiR/0AzsJczV/MBuaL9UdF1M2xpjGGeC6bKIN8N8nwlBA1b5IehtDMhWfS+FyPosdz7ze 1P0sghM/pJVN3bCRfYpP9PoW5h6nfiwSo+NuhXogjxmOMYZmOivpn8GWKJt9zq1zBhEfV8XZ /93jvpA/V5FUP86nVJats8W0KMxxzBW+I8gbcuT8vhT6pLHPCT9Ye5caDOmN7llhIvZ8FS92 4sObKOilkQAONASlwGKqOb/23hRdiNlbX03wuQKHtO+zv1OQzh7UaKOmO9/IOSIXc19z4/1w 510YWcBoHLXjnzbMwSaLHdlbbLkR5FkqnwneycrOD6VN7ILO+5DMI93m0MLQIQa
  • Ironport-hdrordr: A9a23:KRfB/qurFXpm5QUu9QDq17z07skDFdV00zEX/kB9WHVpm62j9/ xG+c5x6faaslsssR0b8+xoW5PgfZqjz/FICOAqVN+ftWLd1FdAQrsN0bff
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Apr 06, 2022 at 02:25:13PM +0200, Jan Beulich wrote:
> Despite the comment there infinite recursion was still possible, by
> flip-flopping between two domains. This is because prev_dom is derived
> from the DID found in the context entry, which was already updated by
> the time error recovery is invoked. Simply introduce yet another mode
> flag to detect the situation and cancel further recursion attempts.
> 
> Fixes: 8f41e481b485 ("VT-d: re-assign devices directly")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.