Re: [PATCH V2 1/2] xen/arm: Add i.MX lpuart driver

[Michal Orzel <michal.orzel@xxxxxxx>]

On 06.04.2022 09:39, Peng Fan wrote:
>> Subject: Re: [PATCH V2 1/2] xen/arm: Add i.MX lpuart driver
>>
>> Hi Peng,
>>
>> On 02.04.2022 07:42, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan@xxxxxxx>
>>>
>>> The i.MX LPUART Documentation:
>>>
>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.
>>>
>> nxp.com%2Fwebapp%2FDownload%3FcolCode%3DIMX8QMIEC&amp;data=0
>> 4%7C01%7Cp
>>>
>> eng.fan%40nxp.com%7Cc7d221ce800342bbd7c108da179e72ca%7C686ea1d
>> 3bc2b4c6
>>>
>> fa92cd99c5c301635%7C0%7C1%7C637848266543058498%7CUnknown%7C
>> TWFpbGZsb3d
>>>
>> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%
>> 3D%7C
>>>
>> 3000&amp;sdata=3CV%2FoJViSFzqRby0h577SiusHRQnC8KiXscntQW%2BZOs
>> %3D&amp;
>>> reserved=0 Chatper 13.6 Low Power Universal Asynchronous Receiver/
>>> Transmitter (LPUART)
>>>
>>> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
>>> ---
>>>  xen/drivers/char/Kconfig      |   8 +
>>>  xen/drivers/char/Makefile     |   1 +
>>>  xen/drivers/char/imx-lpuart.c | 275
>>> ++++++++++++++++++++++++++++++++++
>>>  xen/include/xen/imx-lpuart.h  |  64 ++++++++
>>>  4 files changed, 348 insertions(+)
>>>  create mode 100644 xen/drivers/char/imx-lpuart.c  create mode
>> 100644
>>> xen/include/xen/imx-lpuart.h
>>>
>>> diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index
>>> 2ff5b288e2..0efdb2128f 100644
>>> --- a/xen/drivers/char/Kconfig
>>> +++ b/xen/drivers/char/Kconfig
>>> @@ -13,6 +13,14 @@ config HAS_CADENCE_UART
>>>       This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
>>>       based board, say Y.
>>>
>>> +config HAS_IMX_LPUART
>>> +   bool "i.MX LPUART driver"
>>> +   default y
>>> +   depends on ARM_64
>>> +   help
>>> +     This selects the i.MX LPUART. If you have a i.MX8QM based board,
>>> +     say Y.
>> Why did you move "say Y" to the next line?
> 
> I configured vimrc with " set cc=75,100 ", the "." will be at 80, so I
> move "say Y." to next line.
> 
It won't be at 80 but at 77 which is less than 80 (required by CODING_STYLE)
unless you found a requirement to split lines in Kconfig files at 75.

Cheers,