[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 5 Apr 2022 12:18:07 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2DkQ4pP+5ENn0PQkqkyQdg6DcMTLH1hPRYx0uNcp37o=; b=ggwgCztYQ97yXKVKtCOL3d/NyHoHSOK7MIjFUtSqMO4VoNbWgqMnHdToqW7vDKm1lCK9ExFA0g6MbcKSsON9KsWGgshmtjU9X8ZFfAMhKM6+3ayowULWBGBJuiDhJnJT6apVbJHEZYCYNvLoGYJvqJ+9y3/wail75yqdpDOj695DSfHBfhppzN0uedUNCIFVEYIQ02axa4EBeN5YO9rfNVMFqRaYB0EVpAO1Oyp9/RbSNjzU8qXXPJc6lotqj2QmMkIPr3LatSG+Kblqh6MXSA2U/j9EkH1p0w2XQO8AkOD2JWfTy8gSOhKmg0dQ7yG+Yb897C+b0EFZbkCzx10rGQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mXB3iRtsZQUrVZDQE9pXaGR29eN8uCdYDtsfTpokxlZF+SYwgs3/xCDIQTYEpsGwBqLBcDhs4fbfNZSEMGSlpfJYFTHs8diQpjbcaw16WkLQVBSOFaTpse4LR8qgYD4QLWRMHkHBiwyltfSd3ffGHZkkQU9CfN7ArGz3+4JvTUQgARlCICTDiQzkHwEBIfJkJrpYsDqBIkJHsoR1S34XGv2y9UtuiTfhbeZww9BIGOnfDDLI/9X7ysOsNhwajcty35sIDtsSG5aK56iN837KiGzLrX2VDU85vGGlxfCExpGAMC4bdPpFkA6Xa3h3Le6nFZdCqgNzVVWh/LKbGpx7tw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 05 Apr 2022 10:18:25 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.04.2022 17:05, Andrew Cooper wrote:
> On 01/04/2022 15:48, Andrew Cooper wrote:
>> On 01/04/2022 15:37, Roger Pau Monne wrote:
>>> Setting the fcf-protection=none option in EMBEDDED_EXTRA_CFLAGS in the
>>> Makefile doesn't get it propagated to the subdirectories, so instead
>>> set the flag in firmware/Rules.mk, like it's done for other compiler
>>> flags.
>>>
>>> Fixes: 3667f7f8f7 ('x86: Introduce support for CET-IBT')
>>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> This also needs backporting with the XSA-398 CET-IBT fixes.

I don't think so - the backports of the original commit didn't include
what this patch fixes. I have queued patch 2 of this series though.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.