[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/14] x86/P2M: introduce p2m_{add,remove}_page()
- To: George Dunlap <George.Dunlap@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 4 Apr 2022 13:59:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v+gnQXSiO+emOGmhfMkkLu+WcLM4o9eWK594FRLHyHE=; b=jSOv/Oe0j7R9TCduxwJ3r/B1AS9/3vm5QS9Ts3XYrJ02IXqQz0XwebSQVjt2GU9PtSqSUi+XJBTQk/xkKro0CQzrGIMF3VKuVTPaiPQ21pRWos7duntKzpqXW/kJM+yPLaAGQMXUsxZxWYBXR7LaQR1k8nQR3BQfAVgOLdZNH1jrg12m07enbI+wqFpH1IknMnnBW6ESqSehSoFuUNEym7RbxzC3O5m7pQppEv905HkUjtojZD5FBvx2BIRd3VSzKJeyMljW0XKYMaEKmtM0lUknpcSJ6HdvNUmT0csjFMiY4Qx6lr0Axzg+1cxNKlmpuEzNS3V7RpveofFQ4lnwig==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mmYOiIDe/VmY9Wj5ICR6yJvIkoc9He3sXlEom4TAIBZWC2yMxOypuhgV47Wd/lj7gvYX3aryrK8Xj7Nk5xz5IWl/p5KigCgFqnIwsMYE4Q5eXl8HNPst9PMlSxbvFzcg1L6LSuK+JYa6cXshU5tOISsAN0n5AccMN+2vsK+F/1cBk+l3PjWK/B5cmELDTEVdFP13BAfZt2t5jKPCg78PEOgeUkZQnspuz4wuORs3VCeMuLvm1QBhSFbgAVSMQo7MNon8NY6EINMQz3vMAkGdDcmOHlZ1owKFllqEI95O57E8KnRr1HQStt/exIRMlmqpFihm8QiLU36O4VRtslx5zg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 04 Apr 2022 11:59:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.04.2022 14:02, George Dunlap wrote:
>> On Feb 23, 2022, at 3:58 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>
>> Rename guest_physmap_add_entry() to p2m_add_page(); make
>> guest_physmap_remove_page() a trivial wrapper around p2m_remove_page().
>> This way callers can use suitable pairs of functions (previously
>> violated by hvm/grant_table.c).
>>
>> In HVM-specific code further avoid going through the guest_physmap_*()
>> layer, and instead use the two new/renamed functions directly.
>>
>> Ultimately the goal is to have guest_physmap_...() functions cover all
>> types of guests, but p2m_...() dealing only with translated ones.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Reviewed-by: Paul Durrant <paul@xxxxxxx>
>
> Description reads much better to me — thanks!
Well - thanks to you, as iirc it is largely based on your suggestion.
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
Thanks.
Jan
|
