[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Grab the EFI System Resource Table and check it


  • To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Thu, 31 Mar 2022 07:04:34 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BEZ4+8lCiK5CCg08Xa/aYSvLUSMRRXoOkf5PVqzihkc=; b=mk+EtBYOLijj7jMEHy3HPhceLbUclls3IVwoBj8a91ZUoc5Uh0Tx5c/G0uTsYnS4rtB6fnudnpYFsJHsRKkT82Zbk0Zv7Jf71+WWe5jgnIP3c2VLJjxh0f8Q9oPYKWcJO+Q9G6qZEwd4X65QbF3hylKUmQnanNnasUCLZrFQQsagioCGFkuoPvInFGPg0B8DedzAEy2+LKWiLmYaK2UOZY299LOeyWRr+mFipNEqp2Z49DuPgZslVAit9zHbhPXHGNqqiAOomkvqtZ8tzVrWYv9NmdHvMr+8z0c92zROWLSPK796P8dQOEzn8fPVAhp+bNCL8Br1bSxEb84lc+nt4w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b2O3cyACIkUzNCf7qLCeKoME031h0FgPGRzuT2crObo1iPZzToE1VCGbppc8iEhxJbhFm4x7UKB8b94HGOowgO5hD3gd6WjqiBrllbS9Li0eyzqMo0zFztiMHDbs/lsDJ7SYLN0PBwLE8ocPvW/XpNs84W4GaiVIHwm6VrjVidnShVxn1VdpjEG2yAFpAUxSMznqxdqmZsTmcVC8aeYEp0kSQexg+srBR0kopOw5Z5pJx/SMtJtEGOIw6fgio4rW7wF8aGFkMNHOnPzv6/54Vu16VNrEA5NPxk2InxpYfxr8Pyd4jJ812Q7Yuicefu0sFPTkGeldsAjVEuUzR6BrHw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 31 Mar 2022 07:05:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYRHEH4zzX/uDlcEa4/lbFmRQ7HKzZEkOA
  • Thread-topic: [PATCH v2] Grab the EFI System Resource Table and check it

Hi,

> 
> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> index 458cfbbed4..398a2411a1 100644
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -187,7 +187,8 @@ static bool __init meminfo_add_bank(struct meminfo *mem,
> 
> static EFI_STATUS __init 
> efi_process_memory_map_bootinfo(EFI_MEMORY_DESCRIPTOR *map,
>                                                 UINTN mmap_size,
> -                                                UINTN desc_size)
> +                                                UINTN desc_size,
> +                                                const EFI_MEMORY_DESCRIPTOR 
> *const esrt_desc)
> {
>     int Index;
>     EFI_MEMORY_DESCRIPTOR *desc_ptr = map;
> @@ -199,6 +200,7 @@ static EFI_STATUS __init 
> efi_process_memory_map_bootinfo(EFI_MEMORY_DESCRIPTOR *
>               desc_ptr->Type == EfiLoaderCode ||
>               desc_ptr->Type == EfiLoaderData ||
>               (!map_bs &&
> +               desc != esrt_desc &&

I was going to test it but this line is breaking arm build.

>                (desc_ptr->Type == EfiBootServicesCode ||
>                 desc_ptr->Type == EfiBootServicesData))) )
>         {
> 

I see CC list is pretty small, did you forget to add the maintainers?

Cheers,
Luca




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.