[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] xen: Populate xen.lds.h and make use of its macros
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 30 Mar 2022 14:53:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IOmUkeNxIIgohZhz/Gy7/fAY9TJ9E/y/rdRgferuhFc=; b=b3Eovh3rUwg5M0nPpJtg6Aef4Vw50ez27ywRcwOMBQK8I4QBhimDAwk+oN+V+LdMhJpffZV2cuVu9tZvQUgvCQRHHZ/bpQ16133ox50IgR5Sc34M6qqQRkmif0ecRK+on2q+BJjotpXOVB/LkGu1XeqrQAUGDbxfc25IdyplfNaAqeu0VR6iMV5wgUQvtjwu6t+pTq+1kbHDgNQeiThRmk1m4BIOL8MerrwmJY1g6jpZQR121hMjbEp1nyZfBJhhKmgaf8RMA7/FwhdwpS3qEmISFO8kQW6PJL4C0gNJ1cA+K4U7obHRqluTHZurqIcHp1054A72LFpMVBvMeX4dkw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MuGJOeybjQiYHpSjmtI7MXh50gRGjhNFDS72WXXDt48n4x29JrxaIa4V8AqSu5GGZNylt2tsR4QRl7fI8lc8lcP4srtmZqW9po9muSW3bKY6jrQwwJzpztrk4DcB5MH/kzLOOVItO4A6aoQlJ9MW3B4ChOPb12sYwT6eg/orqTH6DPeNdztomoYukE7wJ26aRBZpmScp7TcxIrG7dQyuDCKI2xGP+vSw9xgPOtpB/JmcFn+bqVbMB9bLCKsrdJ7g7GZYpq3Vlnh7p6OIieOJNlyLPZnaN9uIFOe7kcD6DIaUqmXZqyoFg29zqtKP3xRpquey+f/6zLd25ZoVlGNdKQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Julien Grall <julien@xxxxxxx>
- Delivery-date: Wed, 30 Mar 2022 12:53:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30.03.2022 14:13, Michal Orzel wrote:
> On 30.03.2022 13:57, Jan Beulich wrote:
>> On 30.03.2022 13:04, Michal Orzel wrote:
>>> On 30.03.2022 12:42, Jan Beulich wrote:
>>>> On 30.03.2022 12:32, Julien Grall wrote:
>>>>> Renaming to PE_COFF may help to avoid the confusion with CONFIG_EFI.
>>>>> That said, it would possibly make more difficult to associate the flag
>>>>> with "linking an EFI binary".
>>>>
>>>> Indeed. And EFI_PE_COFF is getting a little unwieldy for my taste.
>>>>
>>>>> I think some documentaion about the define EFI would be help so there
>>>>> are no more confusion between CONFIG_EFI/EFI. But I am not sure where to
>>>>> put it. Maybe at the top of the header?
>>>>
>>>> That's perhaps the best place, yes.
>>>>
>>> In this case how about the following comment at the top of xen.lds.h:
>>>
>>> "To avoid any confusion about EFI macro used in this header vs EFI support,
>>> the former is used when linking a native EFI (i.e. PE/COFF) binary, whereas
>>> the latter means support for generating EFI binary.
>>
>> No, that's the case on Arm only. As Julien suggested, it is perhaps best
>> to explain the difference between EFI and CONFIG_EFI, without going into
>> arch specifics.
> Could you please tell me what you are reffering to as there is no such
> identifier
> in Xen (as opposed to Linux) like CONFIG_EFI ?
Let's call it a "virtual" CONFIG_EFI then; I think we really should have
such an option. But yes, if you don't like referring to such a virtual
option, then describing what is meant verbally is certainly going to be
fine.
Jan
|
