Re: [PATCH v2 2/2] xen: Populate xen.lds.h and make use of its macros

[Jan Beulich <jbeulich@xxxxxxxx>]

On 29.03.2022 11:37, Michal Orzel wrote:
> On 29.03.2022 11:22, Jan Beulich wrote:
>> On 22.03.2022 09:02, Michal Orzel wrote:
>>> --- a/xen/include/xen/xen.lds.h
>>> +++ b/xen/include/xen/xen.lds.h
>>> @@ -5,4 +5,104 @@
>>>   * Common macros to be used in architecture specific linker scripts.
>>>   */
>>>  
>>> +/* Macros to declare debug sections. */
>>> +#ifdef EFI
>>> +/*
>>> + * Use the NOLOAD directive, despite currently ignored by (at least) GNU ld
>>> + * for PE output, in order to record that we'd prefer these sections to not
>>> + * be loaded into memory.
>>> + */
>>> +#define DECL_DEBUG(x, a) #x ALIGN(a) (NOLOAD) : { *(x) }
>>> +#define DECL_DEBUG2(x, y, a) #x ALIGN(a) (NOLOAD) : { *(x) *(y) }
>>> +#else
>>> +#define DECL_DEBUG(x, a) #x 0 : { *(x) }
>>> +#define DECL_DEBUG2(x, y, a) #x 0 : { *(x) *(y) }
>>> +#endif
>>> +
>>> +/* DWARF debug sections. */
>>> +#define DWARF_DEBUG_SECTIONS                      \
>>
>> May I suggest to call this DWARF2_DEBUG_SECTIONS, to make clear no
>> Dwarf1 section is included here (and we also don't mean to support
>> such debug info)?
>>
> As this list is not full I thought we are going to add DWARF1 sections one 
> day.
> DWARF2_DEBUG_SECTIONS would mean that we list sections only from DWARF2 which 
> is not true
> as we have sections from DWARF3,5, etc. 
> Maybe we should leave it as it is but modify the comment to state:
> /* DWARF2+ debug sections */

Well, yes, but only in a way. Dwarf3 and later are simply extensions
of Dwarf2, whereas Dwarf2 is not an extension of what originally was
called just Dwarf and now is commonly referred to as Dwarf1. I'm
fine with a comment saying Dwarf2+, but I'd like to not see the
construct be named just DWARF_*.

Jan