[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/6] xen/cpupool: Create different cpupools at boot time
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 28 Mar 2022 10:07:25 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NFkgP4WjTQcMJvj0Qm4LyqKRctVvhdTkyX5lqOec/E0=; b=AkWzcxpnz25tATpKwfIUeNMXiiAOBXry5xt1u62h2Rny9AmL+xgYrSciZ1uG9fjFnvScn64cxqbvavUTJFi9T+n2T2OtiE4Ysqzsr6ql2mKdSotxNvDy76gwcLx+gbfCsFr6/J7sIUSeNDjAOQZuhokwHiP23qB5/PCcowHIlCBYXBkthohjWjc6PmCXZnUQ0HR5DtwINlz4b9UbKcRRToQtaGg2tHNwjakhw1/dafb5cMYh7Cr7LK++qymFuauM3RKQsC9dKXiqDeF1uE1+MFQpFj+Kk0XIjKNEyrt7B7CXQgHvCWHBcJWn+7zC5H4xQ0rbUXFoNkrwiClfdB4U6A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c+3mdBH+fy9Me+Gg1hCDgbrTlqX7wn2DrgWfMbmyT7wp7jHdjDGz/q7tM2cKrogpOO/YpeL8TPhG+Ti1Wpr524N0NFdYazwI475Ivrn7qA1Hf/DYVfLY+9qit3Jy34f8FjCJJi5W+LsbwHP1fvNDRHaZFr1+Vq3lNyBzLeGWraW3F0A1jPn6ObSTEnKArTmLGknH9O0MoSxfmiSF7GVgnVVNGJ0ob7yejrBB2fG+f4OhgFkgSOd9cWA9gB6ncOHx83leST4mGrHdXUbpz09bj/ibqChd8mC9tYehEdNNoyK+f3gjUEfEquLZFvItHf/WjpJetj2U4mnwR3NBToqchA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>
- Delivery-date: Mon, 28 Mar 2022 10:07:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYP4h9C6K3pTBngUaG+FrEQR6YqqzQyAIAgAPQKgA=
- Thread-topic: [PATCH v4 4/6] xen/cpupool: Create different cpupools at boot time
>> +
>> + if ( !dt_property_read_string(phandle_node, "cpupool-sched",
>
> This should be "node", not phandle_node
Hi Stefano,
Yes sorry about that, I didn’t notice it because in my last test I was creating
pools
with default scheduler, I will pay more attention next time, same applies to the
scheduler swap. I’ll fix them in next serie
>
>
>> + &scheduler_name) )
>> + sched_id = check_and_get_sched_id(scheduler_name);
>
> It would be nice if we had XENLOG_INFO printks to print at boot for each
> CPU:
> - the PoolID
> - the scheduler name
> Not required, but I had to add them to figure out exactly what was going
> on.
I’ve added a printk in btcpupools_get_cpupool_id, do you want me to remove from
there and print here?
Cheers,
Luca
|
