[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time


  • To: Julien Grall <julien@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Tue, 22 Mar 2022 09:52:01 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PyWIPJUwwu0XabSFph4lDMkqweAQuNqdV4dcG/Oq0Nk=; b=EyMWbdKbxbVzHK27qsynf14AMioTwVrEzsH7Mna1aJdSf7AlBx4P1kl0ec4NbXITGiXBeC4onkiyNGYGfJkKIQGvTeCBESFrSXmng9A2FgpiD4VmvkX1Wa1LWxHKUxgykC2jEP67iLCYE7mseD8RJKNDjP4fJJqLH0ifpGcvtrUe9WuXQjRP60b0puMJnWWV5b5yi3dOYx7HqfjgJ0ZVsO/jA4mBCVSbE+HGB/twY6ZRQhgSZxD/2gqy/oQ9kOejPB1GoPG4IDOgJeQqi1+hg03iEP3TCyIda0i1u9qIUP1I22YDrlvbUQ7wOYX9QScoUZYYDbSfJDHncuuGqJRtog==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KOqFaRfFC2CcZOXArxiuMG3V2T3StYa5nLNKpeyBw9UH2439H8MqqRyfpuHJFlVdHmQ+NLdIgIZunFxwSKp6LKoS6HtRieSDI1U3TEreh4oEDh5NbfahLn2xZgx5EY71bb8RQIfrrwi17KEUun91iQkj+rNci8Pg5A3VJiqG5QT3W4M7AIFm9/FnAWVArh6Y9FWiDlP1XMHF3V7KnpMa6IuHxtajkLc2HoL06llVTk4PFp7ng2fdOwnuPzPjON9Hy466YAH0tUiDoU2qQwRU5N+qS/RVsY/Dzqra6X2wbKHQK8ZcrfFyea+z6btDV/hJoJ+Fl/eKVmIMxLv65u2nQg==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>
  • Delivery-date: Tue, 22 Mar 2022 09:52:38 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYOtySiWfuTiIQkkqv44WbBvDftKzFUCoAgASzLoCAAAqAAIABIWCA
  • Thread-topic: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

>>> 
>>> Can you document why this is necessary on x86 but not on other 
>>> architectures?
>> Hi Julien,
>> I received the warning by Juergen here: 
>> https://patchwork.kernel.org/comment/24740762/ that at least on x86 there 
>> could be
>> some problems if cpu0 is not in cpupool0, I tested it on arm and it was 
>> working fine and I didn’t find any restriction.
> 
> What exactly did you test on Arm?
> 

I have tested start/stop of some guest, moving cpus between cpupools, 
create/destroy cpupools, shutdown of Dom0


[ from your last mail ]
>>> 
>>> If dom0 must run on core0 and core0 is Little then you cannot build a 
>>> system where dom0 is running on big cores.
>>> If the limitation is not there, you can build such a configuration without 
>>> any dependency to the boot core type.
>> This might not be completely clear so let me rephrase:
>> In the current system:
>> - dom0 must run on cpupool-0
> 
> I don't think we need this restriction. In fact, with this series it will 
> become more a problem because the cpupool ID will based on how we parse the 
> Device-Tree.
> 
> So for dom0, we need to specify explicitely the cpupool to be used.
> 
>> - cpupool-0 must contain the boot core
>> - consequence: dom0 must run on the boot core
>> If boot core is little, you cannot build as system where dom0 runs only on 
>> the big cores.
>> Removing the second limitation (which is not required on arm) is making it 
>> possible.
> 
> IMHO removing the second restriction is a lot more risky than removing the 
> first one.

I see your point, my concern about moving Dom0 on another cpupool, different 
from cpupool0, is that we give the
opportunity to destroy the cpupool0 (we can’t let that happen), or remove every 
cpu from cpupool0.

Cheers,
Luca



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.