[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] gitlab-ci: add an ARM32 qemu-based smoke test


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Fri, 18 Mar 2022 15:58:40 +0000
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <cardoe@xxxxxxxxxx>, <wl@xxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <bertrand.marquis@xxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
  • Delivery-date: Fri, 18 Mar 2022 15:58:50 +0000
  • Ironport-data: A9a23:5svBl6/W6l6WjbT8c0SaDrUDVH6TJUtcMsCJ2f8bNWPcYEJGY0x3y 2IaXmmCP/fba2P9KY8jOoSypBtQsJOAmoNgSQpqpCk8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw2oHpW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnYCfViAZBIjho8U+Xz1RNCUuG64c6LCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O ZVBMGQwN0WojxtnOmsvBrM7s/+SjCf0bgVa+A+xoIsIyj2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq 2SA+H72ajkQOcaD0zOD/jSpj/XWgCLgcIsIEfuz8fsCqEaPy2IaDhpQTkeyq/S9jk+4WvpPK kgV/Dpopq83nGSwVcX0VRC8pH+CvzYfVsBWHul87xuCooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YXmU7LuToBu5MDIZKmJEbigBJTbp+PG6/tt11EiWCI8+Tujl1bUZBA0c3 RiWgzcZt482oPUq9Kmf9HfD0xSv/IjGG1tdChrsYkqp6QZwZYiAboOu6ETG4fsoELt1XmVtr 1BfxZHAsblm4YWl0XXUHb5TRO3BC+OtamW0vLJ5I3U2G91BEVaHdJsY3jxxLVwB3i0sKW6wO x+7Ve+8CfZu0JqWgU1fPtrZ5ycCl/GI+THZuhb8NIImjn9ZLlPvwc2WTRTMt10BaWB1+U3FB b+VcNy3EVERArl9wTy9So81iOF3mX1gnDqIHc2jlnxLNIZyglbPFd/p13PUM4gEAF6s+l2Jo 76zyePXo/mgbAEOSnaOqtNCRbz7BXM6GYr3u6Rqmh2reWJb9JUaI6aJm9sJItU994wMz7ug1 iztCydwlQuk7VWaeFriV5yWQO62NXqJhSlgZnJE0JfB8yVLXLtDG49ELsppJ+Z7rLI/pRO2J tFcE/i97j10Ymyv01wggVPV9uSOqDzDadqyAheY
  • Ironport-hdrordr: A9a23:zTbuSKBNgTK/MK/lHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/ xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U 4KSclD4bPLYmRHsQ==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Mar 16, 2022 at 06:46:53PM -0700, Stefano Stabellini wrote:
> +curl -fsSLO 
> http://http.us.debian.org/debian/dists/jessie/main/installer-armhf/current/images/netboot/vmlinuz
> +curl -fsSLO 
> http://http.us.debian.org/debian/dists/jessie/main/installer-armhf/current/images/netboot/initrd.gz

    curl --fail --silent --show-error --location --remote-name

I didn't know what all those short options were, I had to write it
down. In script to be shared with others, I think it's better to use the
long options, as it's kind of self-documenting.

Now, there an issue with the command line, "--remote-name" (or -O) needs
to be replaced. We don't care about how the server calls the file, it is
much more important do know where it is going to be stored. Instead, you
should use "--output" to write the file to the location the script is
going to use. It happened to work now, but we don't have to trust
the Internet when not needed.

Also, maybe use "https"?


Also, maybe as an improvement for later, and to avoid having to rely on
the Internet, we could probably store those artifacts in the container
that's going to run the test. But I'm not asking this for now.

> +timeout -k 1 240 \
> +./qemu-system-arm \

There's probably a better way than waiting for the "timeout" like running an
"init" that print something and shutdown the machine. But I guess
that's ok for now.


Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.