Xen project Mailing List

Re: [PATCH v4 11/11] xen/x86: remove cf_check attribute from hypercall handlers

Date: Thu, 17 Mar 2022 17:53:03 +0100

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k6R6j81jF9DUjgfiTwR6joBVvQOeR/OOAhQqaUoMJYo=; b=TWCcvLqfASc6IasmlShXW0s5EjfNglIdsy9HSdtKgWb+1fWpNguTUrzobt2CVXnHj5JpFrejxhAIvHml79iQV4+alx5kKHk2TOKj6hvKIoO3StaKoJPRitmhy80ZD2NU39lWFmqqJk/18ta9rjSTlOt+/kAoI9IuhsxaHstwqebkXK/H6k6X+bhrK8+pMCrvNoTq/dZ+8uurvetXOWwS79N32v57sS4kS1QHGER9wMtOaiPXsLXS8zLoAu19eSjRITSF9Lhs7sDCKbHXzGB8Qwf1MxTFkL+hkt3UzVP+KNGwHnsf85rECwO14kn2iseMYfiEZXsw4EuCmrt4Ip1GAg==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I1QKPTa6RT9B9T2KcPb1F/aSo66BaI9H6UwCJ7z47OOnQuACQpEKh5VmPViuagWpmZrXGWVWw2HiB/wyfbPgKdIT4PE7m9fI4JfI1C7oW5X409a2EzvIbeNJr/dcdjQ2Jw2eDy8EQwnXonyGkWRb3jse96inO3N80hZwc9GbOZOjAKSdexlRaWAzhILSn4EwQsPyLwE+LfjVs1zAgYS3pn28ygXcrC9xfYmIKdXUPPt0/iiPKmB+UYtpXtX13FG6kwAFVuGZm4HHWVuGXPHGD7GxxmELdwVck6FhGi2PgQipVnWOhqByLnIJ8wujh7EaKr85YZXpfWaiaG46Tb64mw==

Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;

Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Christopher Clark <christopher.w.clark@xxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx

Delivery-date: Thu, 17 Mar 2022 16:53:17 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17.03.2022 17:47, Jan Beulich wrote: > On 10.03.2022 08:34, Juergen Gross wrote: >> Now that the hypercall handlers are all being called directly instead >> through a function vector, the "cf_check" attribute can be removed. >> >> Signed-off-by: Juergen Gross <jgross@xxxxxxxx> >> --- >> V4: >> - new patch >> --- >> xen/arch/x86/compat.c | 6 +++--- >> xen/arch/x86/cpu/mcheck/mce.c | 2 +- >> xen/arch/x86/cpu/vpmu.c | 2 +- >> xen/arch/x86/domain.c | 3 +-- >> xen/arch/x86/hvm/dm.c | 2 +- >> xen/arch/x86/hvm/hvm.c | 2 +- >> xen/arch/x86/hvm/hypercall.c | 6 +++--- >> xen/arch/x86/mm.c | 12 ++++++------ >> xen/arch/x86/mm/paging.c | 2 +- >> xen/arch/x86/physdev.c | 2 +- >> xen/arch/x86/platform_hypercall.c | 2 +- >> xen/arch/x86/pv/callback.c | 16 ++++++++-------- >> xen/arch/x86/pv/descriptor-tables.c | 8 ++++---- >> xen/arch/x86/pv/iret.c | 4 ++-- >> xen/arch/x86/pv/misc-hypercalls.c | 10 +++++----- >> xen/arch/x86/pv/shim.c | 4 ++-- >> xen/arch/x86/x86_64/compat/mm.c | 2 +- >> xen/common/argo.c | 4 ++-- >> xen/common/compat/grant_table.c | 2 +- >> xen/common/compat/kernel.c | 2 +- >> xen/common/compat/memory.c | 3 +-- >> xen/common/dm.c | 2 +- >> xen/common/domain.c | 2 +- >> xen/common/domctl.c | 2 +- >> xen/common/event_channel.c | 2 +- >> xen/common/grant_table.c | 3 +-- >> xen/common/hypfs.c | 2 +- >> xen/common/kernel.c | 2 +- >> xen/common/kexec.c | 4 ++-- >> xen/common/memory.c | 2 +- >> xen/common/multicall.c | 3 +-- >> xen/common/sched/compat.c | 2 +- >> xen/common/sched/core.c | 4 ++-- >> xen/common/sysctl.c | 2 +- >> xen/common/xenoprof.c | 2 +- >> xen/drivers/char/console.c | 2 +- >> xen/scripts/gen_hypercall.awk | 2 +- >> xen/xsm/xsm_core.c | 4 ++-- >> 38 files changed, 67 insertions(+), 71 deletions(-) > > But that's only the definitions; for a reason I forget the annotations > are present also on the declarations (really the "also" applies the > other way around; perhaps it was that a future gcc will want to warn > about declaration and definition having gone out of sync). Actually wait, this was nonsense - the declarations are gone by this point, and the awk script adjustment is all that's needed. Acked-by: Jan Beulich <jbeulich@xxxxxxxx> Jan

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.