[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 15 Mar 2022 11:02:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OYHjW+oh1C0V3IAAXUINnLbbiPqWendHECTKZN4od/A=; b=Vad6EM0bcsV/BN3PV37lxYAHA7Y9aMSooq9tLMPW5ano2Fp3zm5xY/OvWR3QeeZdN79EKHA5Jx+fZG5xz2Vqh43h/uHfGnB7N/LbMuwgGrBPHGGd7HzTkj8NG1oM/t1QfB2IFBBYffArrf5LJ8PUWOGooFJBfjAijSGBCRSFgbquG/tDAKDP0FgXjgu9Q2n/jJPcTOPOHurPUFDUYAi+KoCGkqzEShPRgKg1GCiOAb+1jJyXpcNUTHVYh9f3lm4OEIMb+cQPEJ4W8L6qH3MLvND2zU80O6wkHuDcB9gzj9gJDCBXgZwKFRnXtEq256uyHGBI+hM6pyK5YJy0hKyGmQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VBEyGpmrwJBViSqAUEfdGtXADHQxialMu7yzoPIb7VZAd4y5FON5vcYj98ZOIAFYL5htpvhn03kNIgQjGyIw1NbkMdnqHVfSPKvSYEg06UhzIyH9jZt3PrGazTjxnHRjvU6IYI7XDr8t0dsppAfmfD7ZTg5n4PYyq2Z7BFsWjPaQQMqlwxsW+JjqgjOBZhMLW9Sr0ESU7dwVig5MTn20wBNQgWJHe/UBgqmu97UW+o41kwOXZvWycarkefgn1qjNpnqtiwKl/KleH7FmETTYp+OyTZiLX+RwFbGcmPpUAgTID8o7VYuoXQ+gzZ8610fij+QeRL3JXfxz9ZAA/8WzVA==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Julien Grall <julien@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 15 Mar 2022 10:03:09 +0000
- Ironport-data: A9a23:oOnLbqlWGCMDbUrY+bB9stPo5gxfJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIXDWqGafeLYGSje911bNnn8EJTscDVx4RhTAQ5/yE8ESMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DiWl7V4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYUTwzb53sydwhY0cJGA9iGJMa4OTDCC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQ6uBP JFHMWAHgBLoQjB2H3k3JZMCufb4on7cThwA+EK+nP9ii4TU5FMoi+W8WDbPQfSRXtlclEuco mPA/kz6DwscOdjZziCKmlqzgsffkCW9X5gdfJWo+/gvjFCNy2g7DBwNSUD9sfS/klS5Wd9UN woT4CVGha077kmiVNT+dxy+vn+fvxQYVsZQEus18wWEwOzf5APxLmoZSj9MbvQ2uclwQiYlv neLld70AT1ksJWOVGmQsLyTqFuP1TM9dDFYI3VeFE1cvoel8NpbYg/zoshLCJWv3+3VSAnM8 27bpwYiootPlZUP/vDulbzYuA6Eqp/MRw8zwwzYWGO58w90DLKYi5yUBUvztqgZctvAJrWVl D1dwpXFsrhSZX2YvHbVKNjhCo1F8Bps3Nf0pVd0V6cs+D22k5JIVdABuWouTKuF3yttRNMIX KMxkV4JjHOwFCHzBUOSX25XI59ypUQHPY65Ps04lvIUPvBMmPavpUmCn3K40WH3i1QLmqoiI 5qdesvEJS9EVfs9nWDvHbdEi+VDKsUCKYX7HsmTI/OPi+b2WZJoYe1dbAvmgh4RsctoXzk5A /4AbpDXmn2zocX1YzXN8J57ELz5BSNTOHwCkOQOLrTrClM/QAkJUqaNqZt8K90Nt/kEzY/go yDiMnK0PXKi3BUr3y3RMSs9AF4uNL4ixU8G0dsEZg/5hSJ8Pd7xsM/ytfIfJNEayQCq9tYtJ 9EtcMScGPVfDDPB/jUWd57mq4J+Mh+sgGqz0+CNPVDTo7YIq9T1x+LZ
- Ironport-hdrordr: A9a23:v2aFOqr3dvdVDr1nceHy020aV5vPL9V00zEX/kB9WHVpm5Oj+f xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NCZLXXbUQqTXftfBO7ZogEIdBeOk9K1uZ 0QF5SWTeeAcmSS7vyKkDVQcexQuOVvmZrA7Yy1ogYPPGNXguNbnnxE426gYzxLrWJ9dOME/f Snl616T23KQwVoUi33PAhPY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT GtqX212oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iHnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMg4SOo5kv8Z0YxHZ400vsJVXy6 RQxV+UsJJREFfpgDn9z8KgbWAlqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv V0Bs203ocYTbqjVQGYgoBT+q3uYpxqdS32AHTq+/blnwS+pUoJjnfxn6ck7zI9HJFUcegy2w 2LCNUtqFh0dL5lUUtMPpZzfSKJMB25ffvtChPaHb21LtBOB5ryw6SHlIndotvaP6A18A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Mar 11, 2022 at 05:32:45PM +0100, Marek Marczykowski-Górecki wrote:
> On Fri, Mar 11, 2022 at 04:43:22PM +0100, Roger Pau Monné wrote:
> > Sorry, maybe this wasn't clear. My suggestion was not to just do this
> > fix and call it done, but rather to add this check for sanity and then
> > figure out how to properly handle this specific device.
>
> Yes, I agree. Having it properly configured is preferred. Linux manages
> to do that, but I'm not sure how exactly. But ...
I think it might get the interrupt from ACPI data, which is likely out
of scope for Xen. Can you take a look at ACPI data from the box and
see whether the interrupt is reported there? (search for a _CRS method
belonging to the LPSS device)
Sadly the LPSS spec doesn't contain any help regarding the usage of
0xff in the Interrupt Line register. Out of curiosity, can you print
what's in the Interrupt Pin register? (PCI_INTERRUPT_PIN)
Thanks, Roger.
|
