[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] Use g_new() & friends where that makes obvious sense



On 3/14/22 17:01, Markus Armbruster wrote:
g_new(T, n) is neater than g_malloc(sizeof(T) * n).  It's also safer,
for two reasons.  One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.

This commit only touches allocations with size arguments of the form
sizeof(T).

Patch created mechanically with:

     $ spatch --in-place --sp-file scripts/coccinelle/use-g_new-etc.cocci \
             --macro-file scripts/cocci-macro-file.h FILES...

Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx>
---
  include/qemu/timer.h                     |  2 +-
  accel/kvm/kvm-all.c                      |  6 ++--
  accel/tcg/tcg-accel-ops-mttcg.c          |  2 +-
  accel/tcg/tcg-accel-ops-rr.c             |  4 +--
  audio/audio.c                            |  4 +--
  audio/audio_legacy.c                     |  6 ++--
  audio/dsoundaudio.c                      |  2 +-
  audio/jackaudio.c                        |  6 ++--
  audio/paaudio.c                          |  4 +--
  backends/cryptodev.c                     |  2 +-
  contrib/vhost-user-gpu/vhost-user-gpu.c  |  2 +-
  cpus-common.c                            |  4 +--
  dump/dump.c                              |  2 +-
  hw/acpi/hmat.c                           |  2 +-
  hw/audio/intel-hda.c                     |  2 +-
  hw/char/parallel.c                       |  2 +-
  hw/char/riscv_htif.c                     |  2 +-
  hw/char/virtio-serial-bus.c              |  6 ++--
  hw/core/irq.c                            |  2 +-
  hw/core/reset.c                          |  2 +-
  hw/display/pxa2xx_lcd.c                  |  2 +-
  hw/display/tc6393xb.c                    |  2 +-
  hw/display/virtio-gpu.c                  |  4 +--
  hw/display/xenfb.c                       |  4 +--
  hw/dma/rc4030.c                          |  4 +--
  hw/i2c/core.c                            |  4 +--
  hw/i2c/i2c_mux_pca954x.c                 |  2 +-
  hw/i386/amd_iommu.c                      |  4 +--
  hw/i386/intel_iommu.c                    |  2 +-
  hw/i386/xen/xen-hvm.c                    | 10 +++---
  hw/i386/xen/xen-mapcache.c               | 14 ++++----
  hw/input/lasips2.c                       |  2 +-
  hw/input/pckbd.c                         |  2 +-
  hw/input/ps2.c                           |  4 +--
  hw/input/pxa2xx_keypad.c                 |  2 +-
  hw/input/tsc2005.c                       |  3 +-
  hw/intc/riscv_aclint.c                   |  6 ++--
  hw/intc/xics.c                           |  2 +-
  hw/m68k/virt.c                           |  2 +-
  hw/mips/mipssim.c                        |  2 +-
  hw/misc/applesmc.c                       |  2 +-
  hw/misc/imx6_src.c                       |  2 +-
  hw/misc/ivshmem.c                        |  4 +--
  hw/net/virtio-net.c                      |  4 +--
  hw/nvme/ns.c                             |  2 +-
  hw/pci-host/pnv_phb3.c                   |  2 +-
  hw/pci-host/pnv_phb4.c                   |  2 +-
  hw/pci/pcie_sriov.c                      |  2 +-
  hw/ppc/e500.c                            |  2 +-
  hw/ppc/ppc.c                             |  8 ++---
  hw/ppc/ppc405_boards.c                   |  4 +--
  hw/ppc/ppc405_uc.c                       | 18 +++++-----
  hw/ppc/ppc4xx_devs.c                     |  2 +-
  hw/ppc/ppc_booke.c                       |  4 +--
  hw/ppc/spapr.c                           |  2 +-
  hw/ppc/spapr_events.c                    |  2 +-
  hw/ppc/spapr_hcall.c                     |  2 +-
  hw/ppc/spapr_numa.c                      |  3 +-
  hw/rdma/vmw/pvrdma_dev_ring.c            |  2 +-
  hw/rdma/vmw/pvrdma_qp_ops.c              |  6 ++--
  hw/sh4/r2d.c                             |  4 +--
  hw/sh4/sh7750.c                          |  2 +-
  hw/sparc/leon3.c                         |  2 +-
  hw/sparc64/sparc64.c                     |  4 +--
  hw/timer/arm_timer.c                     |  2 +-
  hw/timer/slavio_timer.c                  |  2 +-
  hw/vfio/pci.c                            |  4 +--
  hw/vfio/platform.c                       |  4 +--
  hw/virtio/virtio-crypto.c                |  2 +-
  hw/virtio/virtio-iommu.c                 |  2 +-
  hw/virtio/virtio.c                       |  5 ++-
  hw/xtensa/xtfpga.c                       |  2 +-
  linux-user/syscall.c                     |  2 +-
  migration/dirtyrate.c                    |  4 +--
  migration/multifd-zlib.c                 |  4 +--
  migration/ram.c                          |  2 +-
  monitor/misc.c                           |  2 +-
  monitor/qmp-cmds.c                       |  2 +-
  qga/commands-win32.c                     |  8 ++---
  qga/commands.c                           |  2 +-
  qom/qom-qmp-cmds.c                       |  2 +-
  replay/replay-char.c                     |  4 +--
  replay/replay-events.c                   | 10 +++---
  scripts/coverity-scan/model.c            |  2 +-
  semihosting/config.c                     |  2 +-
  softmmu/bootdevice.c                     |  4 +--
  softmmu/dma-helpers.c                    |  4 +--
  softmmu/memory_mapping.c                 |  2 +-
  target/i386/cpu-sysemu.c                 |  2 +-
  target/i386/hax/hax-accel-ops.c          |  4 +--
  target/i386/nvmm/nvmm-accel-ops.c        |  4 +--
  target/i386/whpx/whpx-accel-ops.c        |  4 +--
  target/i386/whpx/whpx-all.c              |  2 +-
  target/s390x/cpu-sysemu.c                |  2 +-
  tests/unit/test-hbitmap.c                |  2 +-
  tests/unit/test-qmp-cmds.c               | 14 ++++----
  tests/unit/test-qobject-output-visitor.c |  2 +-
  tests/unit/test-vmstate.c                | 42 ++++++++++++------------
  ui/vnc-enc-tight.c                       |  2 +-
  util/envlist.c                           |  2 +-
  util/hbitmap.c                           |  2 +-
  util/main-loop.c                         |  2 +-
  util/qemu-timer.c                        |  2 +-
  util/vfio-helpers.c                      |  4 +--
  104 files changed, 197 insertions(+), 202 deletions(-)

PPC part:
 Reviewed-by: Cédric Le Goater <clg@xxxxxxxx>

Thanks,

C.




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.