[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 4.16] VT-d: drop undue address-of from check_cleanup_domid_map()


  • To: "Beulich, Jan" <JBeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
  • Date: Mon, 14 Mar 2022 04:25:24 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YK9ghu5VnXGGMB1HbKe/q46aWNwKy4qjP3wtzR5zOVI=; b=WjgaixnIxa+du4BAqG/NIHTWWkNFZLMdJwP6PV+RgqrGqbMOFHaXhVcCHAJy388NGWumleE1UVHKvA+qnmoOcXaIMnD1NMQwIq86O02xsVgt6r7xjXBfouWbrCP9mgWKz+9R4wbt9OXseSw4YwUtT2Itg9KNnPELr6wKFvDiIAVbzqi2JUFuyFE33lZoe7KL/6d1C9tSrjfcByQQviEN6ihUdEGQ7ZYRzW+HwdXI4IcR5wK4unxE5ZzC0g5Kv0HCQIy+EcsUk1+Gdh1P1+UgGQA/17Nf/4gjD15x8pUsmTSjjTx8FfUnoHv30vsfWAozCQkWYdDPqMUeNOVwP4/ZEA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oB3Fu+3kAF3Uq+ONwRgN5kGHZ1A/js8NJUAbGMjr5iF3GviBXnnhH4ugYuEAOLHeNCQ0WzoBnL2LLNBhA6DwP0txmdIF3DmWxNnZPFn+AzEHDac4hVgJEXjyoA1wmzrNJFi0z4VR1E50jmtUHiPJo2C+6OQ4Hiwrllc3eqrR6nBer1wcEsUsvw47FjnrZVx39O392veqnqe8PCiJdj+nPulvtDvqKE8oQ4Yhtbbc/OhOrG1J62Upd2MBfpLD6IvBuJLzU45STs5TVzKGFK341YrlH4rUXM+wGZXKPQBuQAUdTPV/IVMQdVW2PC6RgYKhfSiYafPZ0df3Tyxt9sSLcA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
  • Cc: Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Mon, 14 Mar 2022 04:25:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYMwD+JbApDZ2z+USosO8XsFJIAqy+UOtg
  • Thread-topic: [PATCH 4.16] VT-d: drop undue address-of from check_cleanup_domid_map()

> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Tuesday, March 8, 2022 11:27 PM
> 
> For an unknown reason I added back the operator while backporting,
> despite 4.16 having c06e3d810314 ("VT-d: per-domain IOMMU bitmap needs
> to have dynamic size"). I can only assume that I mistakenly took the
> 4.15 backport as basis and/or reference.
> 
> Fixes: fa45f6b5560e ("VT-d: split domid map cleanup check into a function")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

> 
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -197,7 +197,7 @@ static void check_cleanup_domid_map(stru
> 
>      if ( !found )
>      {
> -        clear_bit(iommu->index, &dom_iommu(d)->arch.vtd.iommu_bitmap);
> +        clear_bit(iommu->index, dom_iommu(d)->arch.vtd.iommu_bitmap);
>          cleanup_domid_map(d, iommu);
>      }
>  }


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.