[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] x86: avoid SORT_BY_INIT_PRIORITY with old GNU ld
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 11 Mar 2022 15:34:29 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BIp9enZ6Td5IPjrl0a4wgylfAVxySYGj9CkFtleIuvw=; b=TQfL8TFGGOuQltlG9+l2LO0lF1PUNVnlDf8aP3+Vksj9qhjaVcPhE9ivNRgVZ6Ltu0eHNNq+5OT6idpyH3phQEw5yBAWsYeYWcjreSkf57SvTI0EHpPf6P/Sn9YvZlHHPPlBvzCETXJDzJzC1qiyTAvdn9FF9GkgD4uLD1imqBhZKt4CH6smghWNgliwyGKVZJ8gSWaDtAQiQpy3cVp67t/rtQM3X/WksvIpPcXd53eC2ztUyDOq5fpF08nypk8WYiVBYju8NO4qUG3vpnAeCDA1O2X8ak4y62yIn6uAVx6f++Kb3dByw6xDbTLhDiFblYWGWUwlOC3PfB0s3HyzKg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eJ9Rw2oVhIQS1ZuDBjbcnlsYNwvHPeXAouxW4PPaXQUrcv3a0HN5t67QifkcFS/ZqL7f/9nkteFd2DDj3YccsIhQbmPmjfHrVy6lrYCycZcorMqItTqLVlqNzcGdFNaI7t/3zuFR5C6vhD02LDnucd/VIHS2B53bfvdhTK2jDG0pKrDBatPimGpZDpLC47Qyr6sWui1SElW9/guC3IlbqpsOprjmajiIDR3/fyUqsdycrGRf0p3FdkHM8EnJT3DrAkymxixZ80+zbvjEeK8OJKAwAiLE4Hwt7JPT9ymrvAg9gNKAyXtLZEnToZaPJnbAHF2/If9iQbPzH02LlWY4HQ==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 11 Mar 2022 14:34:48 +0000
- Ironport-data: A9a23:/Rz0qaj3rjRt997EIyVNqE7sX161dhAKZh0ujC45NGQN5FlHY01je htvUT2BO/jcM2ajet92aYTko04Ev5PXytViHQI4pCowRiwb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhWFrU4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YSkLJrDGlL4UaAJBNiR5N7BXoKbMHmfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiAO 5NENmY2BPjGSx8QHAtGKIwMp92LoiPELh8EmHmsnINitgA/yyQuieOwYbI5YOeiWsF9jkue4 GXc8AzREhwccdCS1zeB2natnfPU2zP2XpoIE7+1/eIsh0ecrkQRAhALUVqwodGil1WzHdlYL iQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4Pc8i9QuBkKPv+B+8A28OUy8ZcdcZq5pjLdA17 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoCtQVnNL ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT0uDA3Dt4ade51q2VtW lBdyqByC8hUUfmweNSlGrllIV1Qz6/t3MfgqVBuBYI90D+m5mSue4tdiBknehs3Y51bJm+xO BaN0e+02HO1FCL7BUOQS9jsY/nGMIC6TYi1PhwqRoYmjmdNmP+vo3g1OB/4M5HFm0kwi6AvU ap3gu73ZUv2/Z9PlWLsL89EiOdD7nlnmQv7GMCqpzz6gOH2TCPEFt843K6mM7lRAFWs+16Or b6y9qKiln1ibQEJSnKOoNBJcgxScyRT6FKfg5U/S9Nv6zFOQQkJI/TQ3akga8pimaFUnf3P5 XazRglTz1+XuJENAV7ihqxLAF83YatCkA==
- Ironport-hdrordr: A9a23:yJWeu6DFTQAgUQ3lHehAsceALOsnbusQ8zAXPh9KJiC9I/b1qy nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHP9OkPIs1NKZMjUO11HYTr2KgbGSpgEIXheOi9K1tp 0QDZSWaueAdGSS5PySiGLTc6dC/DDEytHRuQ639QYTcegAUdAH0+4WMHf+LqUgLzM2eabRWa Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+6Z/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUR4S0LpXXt WGMfuspcq/KTihHjDkVyhUsZaRt00Ib1i7qhNogL3X79BU9EoJunfwivZv3Evoz6hNO6Ws19 60Q5iAq4s+PfP+TZgNc9vpEvHHfFAkf3r3QRCvyBLcZeQ6B04=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Mar 11, 2022 at 02:28:40PM +0100, Jan Beulich wrote:
> Support for this construct was added in 2.22 only. Avoid the need to
> introduce logic to probe for linker script capabilities by (ab)using the
> probe for a command line option having appeared at about the same time.
>
> Fixes: 4b7fd8153ddf ("x86: fold sections in final binaries")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> v2: Always define HAVE_LD_SORT_BY_INIT_PRIORITY when using LLVM ld.
>
> --- a/xen/arch/x86/arch.mk
> +++ b/xen/arch/x86/arch.mk
> @@ -73,6 +73,16 @@ ifeq ($(CONFIG_UBSAN),y)
> $(call cc-option-add,CFLAGS_UBSAN,CC,-fno-sanitize=alignment)
> endif
>
> +ifeq ($(call success,$(LD) --version | head -n 1 | grep -q "GNU ld"),y)
You are not going to like this, but I think this should live in
xen/Kconfig together with CC_IS_{GCC,CLANG}, ie: LD_IS_GNU or similar.
It's possible we will need this in the future in other places, so
having it in Kconfig makes sense.
> +# While not much better than going by raw GNU ld version, utilize that the
> +# feature we're after has appeared in the same release as the
> +# --print-output-format command line option.
> +AFLAGS-$(call ld-option,--print-output-format) +=
> -DHAVE_LD_SORT_BY_INIT_PRIORITY
That's fine to have here IMO.
Thanks, Roger.
|
