[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/blkfront: speed up purge_persistent_grants()


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 11 Mar 2022 12:01:40 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7r+XHGjRDZfJFK8qVKqeLX5YluqIfaqF+fN63ptoViM=; b=kqowpKl9+jiu/D7ulcILiWQ4P1t22oT/Dm5hNdZEdxLIdp7/Znu9P72+wpKjjt0sniN0Oeu95M/NUZFO+SQkKbygZ29Vay7FyzZ2US63PRUXT2xngk3JlNXMi92capKB2OdKz4OSvx67E8CABo5k5MvSMLszxWn0duNOiu1ViiFu2tnQ7qFWGmqiRYUNYTb212ZvjimPArR6nqHIhw7vqnw+pzeMS6wBgLwVF+5mikToj0NTiqb7kMGI1xppy6c06ENz9A3Fa4bT2tGgEmeXOC2x5viy1EYsquWaGGnKm10WbEE3sa7vBorYZRyr4T0GNaTqcbftzJfofoxOA/P9zQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LEiWyupErfhEk0a5x0tQH4FhUD58IQIcepJ9CkxWd/sxWOyhtiRXJgAjRVnmjSM9B7a/MUUj5dbplIhg29Yodxg9tOhMmCQZv5FtZ7VK3zwDQ1AyX2Afo5y8xXcalSVo7jnpGOUTQLV7OvCtjw5+ynIIxhkHfXcOrWn9VZbmoupDhxxRySyj2dXvo+LDmehUtjZOTLSxGweInJIw4tNvkoqMIlbh/R6F88DBbNcBTy0KldCVHLAehgmUsSeSRpbXpSgcRijc2Q0JhRGbxQYI+xsk0vMef7QqGiMInH6T7oOm+VS/WjAQfLbFQ9xGGEXW9D18VlPW/5HvJqSUyLccKw==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <linux-block@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • Delivery-date: Fri, 11 Mar 2022 11:01:58 +0000
  • Ironport-data: A9a23:PvFD16v87McJy26zE3mMDyL8zOfnVMteMUV32f8akzHdYApBsoF/q tZmKT+OO/bYYTT2fNpzaIS1oEoDsMTUm4VgHFM/qyxgH38b+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1jU4 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8wIoPSnN88CiVkMDNdYO5l+4f+Kz+W5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yj7UF7A+SI3rSKTW/95Imjw3g6iiGN6AO ZJBOGAwMHwsZTUWYVocL8sCod2hlz6iVhtnunWuj7Metj27IAtZj+G2bYu9lsaxbd5Ogk+Sq 2bC/mL4KhIXLtqSzXyC6H3EruXIhyLgHoUJCKe/6OVpkXWU3GUYDBBQXly+ydG7gEOjX9NUK 2QP5zEj66M18SSDR8n3WBCQo3OeuBMYHdZTe8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLT5gqrqOUlqG66yZ6zi1PEA9KW4EeD9BTgYf5dTniJ88gwiJTdt5FqOxyNrvFlnYx zGMsTh7jbEUhs0jyaq25xbEjiiqq5yPSRQ6jjg7RUr8sFk/PtT8IdX1tx6Ltp6sMbp1UHGYo FYan/O/tdwyLoOuyW+uQ900FvaAsqPt3CLnvXZjGJwo9jKI8nGlfJxN7DwWGHqFIvroaheyP haN5Fo5CIt7eSLzMPQpO97Z59ECkPC4fekJQMw4eTanjnJZUAactB9jakeLt4wGuBh9yPpvU Xt3nCvFMJr7NUiF5GbnLwv++eVyrszb+Y81bcmqp/hA+eDCDEN5sZ9fbDOzghkRtctoWjn9/ ddFLNetwB5CSuD4aSS/2ddNcQ5bdidkVciu8pI/mgu/zuxOQTBJ5xj5m+5JRmCYt/4NyregE o+VBie0N2YTdVWYcF7XOxiPmZvkXIplrGJTAMDfFQ3A5pTXWq72tP13X8JuJdEPrbU/pdYpH 6htU5jRWZxnF2WYkwnxmLGg9eSOgjzw3lnQV8dkCRBiF6Ndq/vhoYa1IFGwqHFQUkJad6IW+ tWd6+8SerJaLyxKB8fKcvO/iVS3uHkWguVpWEXUZNJUfS3RHEJCcUQdUtdfzxkwFCj+
  • Ironport-hdrordr: A9a23:3gXLcqOAfiKg+sBcTjujsMiBIKoaSvp037BK7S1MoNJuEvBw9v re+MjzsCWftN9/Yh4dcLy7VpVoIkmskKKdg7NhXotKNTOO0AeVxelZhrcKqAeQeREWmNQ96U 9hGZIOdeEZDzJB/LrHCN/TKade/DGFmprY+9s31x1WPGZXgzkL1XYDNu6ceHcGIjVuNN4CO7 e3wNFInDakcWR/VLXAOpFUN9Kz3uEijfjdEGY7OyI=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Mar 11, 2022 at 11:35:27AM +0100, Juergen Gross wrote:
> purge_persistent_grants() is scanning the grants list for persistent
> grants being no longer in use by the backend. When having found such a
> grant, it will be set to "invalid" and pushed to the tail of the list.
> 
> Instead of pushing it directly to the end of the list, add it first to
> a temporary list, avoiding to scan those entries again in the main
> list traversal. After having finished the scan, append the temporary
> list to the grant list.
> 
> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.