[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC
- To: Jane Malalane <jane.malalane@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 9 Mar 2022 14:23:08 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t6wfWfh1Q3I4yPNq/WpipMeqY+xy9cpYPKhae/68H+w=; b=OIRheWWLrqmUmB7F6DJ/GOpgqU2o0NMq2gCd5uHqOEjCUsz0lJe5t1NVN/h7Bzm/ZJcqJ4FUgz9y18QMhgBbOrZmRMCk5tmndDWqvPoPdMaHIvHtbG4SitzME8NW9lzOxLFSxPKP+9sxIlESVMOXx04oKF47Dklvth/jJ5W0p1CEZCfqiJYHuCvptx9+MVRhSp+HiACp23iH3duHw5/CbIzggzgXPnMl/ea3A6sTJoktthqjbmPv8XlrSH7OtGgZv03/CQYX2h/nGlyhkL9pb1RhE6hgOewlQuJZXvBg+o8PUHZsjnoyugtzQDpU5Tm5UiTVfJuufiMy98NO2tqewQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CxFIfXruC3VsWZjxmGQdkO26zqgl75AH5ejB1rDVKfklmMQHksbBgzh02XanuRiBMM7UwBJCbpJUe1Tw8dY6t9DqS4r5W3dDkiDAdQoJ4GxtHF3TlrrvhjdA7CPzVgK7EusrVkSyepQG53lFluGo+8c+pbem5Ny3oiSUmmSgG2d9cbFkUleOefXJz8XnnNrsP8/0OxftAg5ABLoItuMH1zQz/IwW840bMZ8RjFoJqS9hh8FgYgtNPX4YTciKboPGO3jbLm4vlHqq5RKKNZEq70z9wU8TCExm1WgZNOnxhjmORpknwTZJGj2OHY9rp+3I+RL3lqw6znBY+vKC7lLkKg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 09 Mar 2022 13:23:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.03.2022 18:36, Jane Malalane wrote:
> @@ -685,13 +687,31 @@ int arch_sanitise_domain_config(struct
> xen_domctl_createdomain *config)
> }
> }
>
> - if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED )
> + if ( config->arch.misc_flags & ~(XEN_X86_MSR_RELAXED |
> + XEN_X86_ASSISTED_XAPIC |
> + XEN_X86_ASSISTED_X2APIC) )
> {
> dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n",
> config->arch.misc_flags);
> return -EINVAL;
> }
>
> + if ( (assisted_xapic || assisted_x2apic) && !hvm )
> + {
> + dprintk(XENLOG_INFO,
> + "Interrupt Controller Virtualization not supported for
> PV\n");
> + return -ENODEV;
> + }
> +
> + if ( (assisted_xapic && !assisted_xapic_available) ||
> + (assisted_x2apic && !assisted_x2apic_available) )
> + {
> + dprintk(XENLOG_INFO,
> + "Hardware assisted x%sAPIC requested but not available\n",
> + assisted_xapic && !assisted_xapic_available ? "" : "2");
> + return -EINVAL;
> + }
My understanding of the outcome of the prior discussion was the opposite
use of EINVAL and ENODEV respectively.
Jan
|
