[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC
- To: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 8 Mar 2022 17:22:36 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sSfz3JrLBHR4TCcvnQS5kyjyxRvABmDE0EWhL3JGJxY=; b=ZHrFj9ZYznHVDMZrXQbo798LdN3wgW/48FFhHVZev9rBut96oXCYJqnW9swN7G352NHPd63kYzYI1DMxDIDn32vk0YdUXq7ds4wKm33MIs99P3V14BTx157Q9glnxc4SGW3hT8fCA1aSX+5LAHVSXpRLg31BLyyMIcY873nSLUueP5qUNSmv5dehSrQhitm6onVw/VYVs9Qm6r7CGlffcWLZZIoLkwIkryKmPiAFi07myIYDE17PWdZeVJjSi70M/RPa5BS6wYaHV6T5FrbDYpOjM1j/u1WjDqP2tGFGf3KuwxcK6Ul/UHx2z/Bs8nCV9Db32kTIcmF/R3lHgMMPBA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GBSnIszL6TeG6MzsilOqWKq7yE/e6fpou60SfEzEIbgSQe4oU7m2l9Jd73dBxTbp+pJngxa2yDlfjMP6Rpr7nC7O0jul6mWjkwxFAw+y7J5azCBCoieYWf12FMuzhZYa/Z3cNdypEZp+kuzrnO94nwF/IzQt9HBOyJdlKx4AXAiTX7ULH8UtwkjilXhMPlIWsgqd2G/p80friPfyzvet8FwOhJBRZ5WVyQ2XcN+sMbh2DjzLH3xrzNvxYFAPrBX2AFOhI5BBnLIyw2T09k0JPPk6FjhOcRxWHm0hKg0g6ECmUtryT7nK1gYsQc4ZyhdjAZyUYrA6whaq1NJexPrQ9w==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 08 Mar 2022 16:22:48 +0000
- Ironport-data: A9a23:fePWpqhC69+/MUDOLpUb9QtiX161nBAKZh0ujC45NGQN5FlHY01je htvWz+OOvyPZTH3L4h1at6w9xgC75SHmIM3TFZv+StjQSob9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhWFvd4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YSUjZ/XeurwQakJVKTFaBJFi3Jn4P0Hq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiDP ZJAMGYyBPjGSy9CNXMLGpkipceLn1LPfSd0hGO2+oNitgA/yyQuieOwYbI5YOeiXt5Jl0yVo mbH+WXRARwAMtGbjz2f/RqEhPLLnC79cJIfEvu/7PECqGOUwmsfGRgHT2yRqPOyilO9c99HI klS8S0rxYA+/VKmZsPwVBq5pDiDpBF0c8VUO/037keK0KW8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq19L2ZsDezMig9NnIZaGkPSg5ty9vsuoYolTrUU81uVqWyi7XI9SrYm m7Q6nJk3vNK0JBNh/7TEU37byyEhJKQFhwXvgjuBW+f/idAWKqBQbO20A2OhRpfF7qxQl6Et XkCvsGR6uESEJ2A/BCwrPUx8KKBvKjcbmCF6bJ7N9x4rmn2pSb/FWxFyGwmfC9U3tA4lSgFi aM5kSdY/9dtMXSjdsebiKrhWp1xncAM+TkIP804j+aigLAsLGdrHwk0PCZ8OlwBdmB2ycnT3 r/BLa6R4Y4yU/gP8dZPb751PUUX7i4/33jPYpvw0g6q17GTDFbMF+tbbgTeM7tgvP7fyOkwz zq5H5HRo/m4eLeiChQ7DKZJdQxaRZTFLcqeRzNrmh6rfVM9RTBJ5w75yrI9YY1195m5Zc+Tl kxRrnRwkQKl7VWecF3iQik6NNvHAMYuxVpmbHdEFQv5hBAejXOHsf53m20fJuJ8qoSODJdcE pE4Ril3KqgXGmSdpWVHNsWVQU4LXE3DuD9i9hGNOVAXV5VhWxbI6pnjeA7u/zMJFS25qY01p LjI6+8RacBrq9hKZCoOVM+S8g==
- Ironport-hdrordr: A9a23:7ZdYgKpYPv/6+C3NnggrmGkaV5vJL9V00zEX/kB9WHVpm5Oj+P xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu v52iIRzADQBkj/I/7LTkUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF K12TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2+ XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LvEbQN/L/AEqZNScxPf5UZllsp7yr h302WQsIcSJQ/cnQzmjuK4GC1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+ NjZfusqMq+SWnqLkwxg1MfgOBFBh8Ib1S7qwk5y4GoOgFt7T5EJxBy/r1cop8CnKhNP6Wsqd 60d5iAr4s+PfP+XZgNdNvpfvHHeFAlYSi8Rl56cm6XXZ3uBRr22uvKCfMOlaWXRKA=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Mar 08, 2022 at 04:16:21PM +0000, Jane Malalane wrote:
> On 08/03/2022 16:02, Roger Pau Monné wrote:
> > On Tue, Mar 08, 2022 at 03:44:18PM +0000, Jane Malalane wrote:
> >> On 08/03/2022 11:38, Roger Pau Monné wrote:
> >>> On Mon, Mar 07, 2022 at 03:06:09PM +0000, Jane Malalane wrote:
> >>>> diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
> >>>> b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
> >>>> index 9119aa8536..5b7d662ed7 100644
> >>>> --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
> >>>> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
> >>>> @@ -220,6 +220,9 @@ void vmx_vmcs_reload(struct vcpu *v);
> >>>> #define CPU_BASED_ACTIVATE_SECONDARY_CONTROLS 0x80000000
> >>>> extern u32 vmx_cpu_based_exec_control;
> >>>>
> >>>> +#define has_assisted_xapic(d) ((d)->arch.hvm.assisted_xapic)
> >>>> +#define has_assisted_x2apic(d) ((d)->arch.hvm.assisted_x2apic)
> >>>
> >>> Those macros should not be in an Intel specific header,
> >>> arch/x86/include/asm/hvm/domain.h is likely a better place.
> >>
> >> Actually do you think hvm.h could be better?
> >
> > I guess that's also fine, I did suggest hvm/domain.h because that's
> > where the fields get declared. I guess you prefer hvm.h because there
> > are other HVM related helpers in there?
>
> Yeah, that is why - tsc_scaling_ratio also gets defined in domain.h for e.g.
I'm fine with placing it in hvm.h.
Thanks, Roger.
|