[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- Date: Tue, 8 Mar 2022 16:13:04 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n2tesfGqKKQZ3sTBGGMzuzCB4pZuYikofZ3Le0PsZzA=; b=i7qUKCVLSVF7LEjz1f5RqyRntT2PFmXA7OniTdNcw7+xRp/CDusvkJT4b19i3GxnxiKBfXN1pNDm/6i8BTPPTlQKutWdmhpxBDlraEtuVDXDr1BTU7ZmwHqwgXN3npdi6GqYHSLbiXkJlmNkRArA1ltJnUrqtmKzQXO7HiqOETU9iDKsYr49+L/PG7jw6If9MorR3dwdprm3DAVKXNW1wB4nMJsvipW5YeHvpReSccOsLf7+dRIFZWwn+rs8QAEJOHEFQLxtu4ma8Cptvb9WgMD4LuiunUDAp299G6xxfuMvQMEU4tBCkByVcYvvN9AXVX7lixlnq+daBwxRxWqVvQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rf8SSf5sAPGpSolnV28m2MYsfVMyJxVh3s7yk4fic+oYPR+ckdH+vG8DEZzPbq929OkvJF8weA0zZCtrgK7g4euWZLJNATlHMCGtYWMddSLa8qQ/1hbUphO4wGaqLFadJs3EkparW9tZQlQPENiNOBrmn4/hHUMjr8zbc/CnF6TMiQ92CA2cKjgib0phzkW7RbdnrEEeLguoyD1+SA4WJc9nXNRMRo0DYyaqQtIhjkR0Lo4u0Scj4kteNYc0ibxN7ijEQjnFtTa+iRrgAc4T3kx63X4dlnwq76rMzCNEik8CAi93XPrBl4FmwXdiraOHIZmQdjaKYGJ4SuAxOSKmjw==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "Anthony Perard" <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Andrew Cooper" <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 08 Mar 2022 16:13:18 +0000
- Ironport-data: A9a23:wN/I8qNmDVLSl/jvrR1dl8FynXyQoLVcMsEvi/4bfWQNrUoq1TVUz GJJWG3UM/eOMWKmf9t/at+woBlS7JDcz9NkHgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZi2t4w27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z8 Ml3mbexRl8SYvfGucAxdl4fFgVTBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALDsDtMcU6s3VpyTjfAN4tQIzZQrWM7thdtNs1rp4TQqyPP 5FJAdZpRCrgOBASYQo0NLcVjNyW2yfwQjBa8k3A8MLb5ECMlVcsgdABKuH9YceWTM9YmkKZo GPu/GnjBBwectuFxlKt8G+oh+LJtTP2XsQVDrLQ3sBthFqf12kCEio8XFGwoeS6okOmUtcZI EsRkgIipLY/3FamRd78W1u/unHslgEYc8pdFas98g7l4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9S3iQ67OVpjOaIjUOICkJYipsZQkK+d74u6kokwnCCN1kFcaIYsbdQG+qh WrQ9W5n2utV3ZVjO7iHEU7vuy6WirPIQVYOul/df0aJy0Q+YaqIXtn9gbTE1spoIIGcR1iHm XELncmC8ewDZa2weDyxrPYlR+/wuavcWNHIqRs2RsR6qWzxk5K2Vd0IuFlDyFFV3tHokNMDS Gvaoktv6ZBaJxNGhocnMtvqW6zGIUUNfOkJt8w4jPITOvCdlyfdpUmCgHJ8OUi3yCDAdollZ f+mnT6EVypyNEie5GPeqx0h+bEq3Dsi4mjYWIr2yR+quZLHOiLLF+hVbQDXPr1ihE9hnOkz2 4wEXydt408DONASnwGNqdJDRbz0BSJT6W/KRzx/KbfYf1sO9JAJAP7N27IxE7GJbIwO/tokC kqVAxcCoHKm3CWvAVzTNhhLNeO+Nb4i/ClTFXF9Yj6VN40LPN/HAFE3LMBsI9HKNYVLkJZJc hXyU5nYUqQVFGWdoGh1gFuUhNUKSSlHTDmmZkKNSDM+Y4RhV0rO/NrldRHo7y4AEmy8ss5Wn lFq/lmzrUYrL+i6MPvrVQ==
- Ironport-hdrordr: A9a23:OffTl6Mi85eQXsBcT3b155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjzjSWE9Qr4WBkb6LW90DHpewKRyXcH2/hsAV7EZniohILIFvAu0WKG+VPd8kLFh5dgPM tbAstD4ZjLfCJHZKXBkUeF+rQbsaG6GcmT7I+0pRYMcegpUdAa0+4QMHfCLqQcfngjOXNNLu v72iMxnUvGRZ14VLXYOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LPErXoBerR8bMRiA0DkAgMbzaBB+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jRiuKYlGclsRLYkjQpo+VY7bVfHwZFiFP MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TpE5lpdwNZakmYL9Zo7RZUB7+ PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZeo6EmOIr4Sy7KQ+5emsdpBNxJwumI 7ZWFcdrmI2c1KGM7z44HSKyGG4fIyQZ0Wf9igF3ekIhlTVfsuYDRG+
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYMjUEaMoAwzVpzE69n4F8Ciyydqy1XcmAgABEiACAAAUagIAAAtSA
- Thread-topic: [PATCH v5 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC
On 08/03/2022 16:02, Roger Pau Monné wrote:
> On Tue, Mar 08, 2022 at 03:44:18PM +0000, Jane Malalane wrote:
>> On 08/03/2022 11:38, Roger Pau Monné wrote:
>>> On Mon, Mar 07, 2022 at 03:06:09PM +0000, Jane Malalane wrote:
>>>> diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
>>>> b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
>>>> index 9119aa8536..5b7d662ed7 100644
>>>> --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
>>>> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
>>>> @@ -220,6 +220,9 @@ void vmx_vmcs_reload(struct vcpu *v);
>>>> #define CPU_BASED_ACTIVATE_SECONDARY_CONTROLS 0x80000000
>>>> extern u32 vmx_cpu_based_exec_control;
>>>>
>>>> +#define has_assisted_xapic(d) ((d)->arch.hvm.assisted_xapic)
>>>> +#define has_assisted_x2apic(d) ((d)->arch.hvm.assisted_x2apic)
>>>
>>> Those macros should not be in an Intel specific header,
>>> arch/x86/include/asm/hvm/domain.h is likely a better place.
>>
>> Actually do you think hvm.h could be better?
>
> I guess that's also fine, I did suggest hvm/domain.h because that's
> where the fields get declared. I guess you prefer hvm.h because there
> are other HVM related helpers in there?
Yeah, that is why - tsc_scaling_ratio also gets defined in domain.h, for
e.g.
Thank you for pointing this out,
Jane.
|
