[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/2] xen/build: put image header into a separate section


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 8 Mar 2022 15:25:23 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K5ltZMPfb1En8ZRTwyaZ2htxvbkAIRqrbEdV8aWrCJk=; b=JSX91YG7gsvsoZwL+QGKK8hgNNAdePr95lzN0lqBhQs3TU1jMjqlxWt4EqBsyCWgYebnYovYHRfieYqOLKvg88acb1pzg7dehJJnuy7MTGmcNdijupgD5G3J43DOn4RLMfJe3F9ygfz88GX3eR7CZWbOLRrA7Tle1/sRIptSr7uI11fKKzBZwehUJbrOkK1jEdqzT0mXloVEQ9rLzjydFIOyfrewTXIubVTvVNVxurEfLBg/Ur9FiamALqdHeMP0eT6WsQiCNfbUfaz0JMLCz/n4Vw1DHdQ6OETdHEwLBvpFgZixgRtVG/Dq3aUxI7w8V4RMFbrFG2bF/PqjvK3K1Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qol8O1aWTeKTgkjOBdGziA4SAL7MsAi3oQmeMqfd0P1z0BlPGXbMXZuFZpfNTswT+72dEYMLxu5DxGPbO63tYOWnlRpvd/MzCP66RBnpGDWfdpZ/rpKv21DFsbV5pnJMeHLkmdyEaYVzeWXubTfKBP+sUyjZ2aWYaXv3JM56WL80l8A4q/Uu5HgrPU+7zgwNyOseferUkcdWX5U+f9l0YoSaE1gWKJgaMiZd385mO6Ww+69U9TEnZWS+VT5pK9y+2+7stD4e/rzy5BLfEseCKa/EVZrx9QDezU9WZ2GwDL2V5SiEV5CEvjmGaNh4POAT5/PiI6AzpJJIBrnaEL/P0w==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 08 Mar 2022 14:26:00 +0000
  • Ironport-data: A9a23:Fwm+mKJm7of2nVCDFE+RJZUlxSXFcZb7ZxGr2PjKsXjdYENS1DUEm DdMXT+PMvyPYzbyetpzPtjn8RkH75fcz9MxHQVlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2dY42YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 MR2iaWSaVkoApHJl7teWQJDSC0lDZQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glg3p4WR6iFD yYfQQJydCXDbSV9AUw0LK4Tl8y0iWPvUwQN/Tp5ooJoujOOnWSdyoPFDt3RfdCbQNRPqWyRr GnG4mfRDwkTMZqUzj/t2nCmi/LLnCj7cJkPD7D+/flv6HWMwkQDBRtQUkG0ydGzh1SiQdtZJ woR8zA3sKkp3EWxS5/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceXic23 1WEm9foAz1Hs7CPT3+ZsLCOoluaOzURLGIETT8JS00C+daLnW0opkuRFJA5Svfz14CrX2Grq 9yXkMQgr6Qosfcp9/u6wWzCjG3vrIPSFQJu1jyCCwpJ8ThFTIKiYoWp733S4vBBMJuVQzG9g ZQUpySNxLtQVM/QzURhVM1IRej0vKjdbFUwlHYyR8FJyti7x5K0kWm8ChlaLVwhDMsLcCSBj KT76VIIv8870JdHgMZKj2ON5yYCkPCI+TfNDKm8gj9yjn5ZLlfvEMZGPxL44owVuBJw+ZzTw L/CGSpWMV4UCL580B29TPoH3Lkgy0gWnD2PG86kn0n8iOrDPxZ5rIvp1nPUNYjVC4ve/G3oH yt3bZPWm32zrsWkCsUozWLjBQ9TdiVqbXwHg8dWavSCMmJb9JIJUJfsLUcaU9U9xcx9z76Ql lnkAxMw4Aev1BXvdFTRAlg+OeyHYHqKhS9iVcDaFQ3zgCZLjEfGxPp3SqbbipF7rLwzl6AlF aJZEyhCa9wWIgn6F/0mRcCVhKRpdQixhBLIOCygYTMleIVnSRCP8djhFjYDPgFSZsZrnaPSe 4Gd6z4=
  • Ironport-hdrordr: A9a23:TuM+TKv8TiaBUpQ41cPabD6S7skDctV00zEX/kB9WHVpm6uj5q eTdZUgpHvJYVMqM03I9urtBEDtexzhHP1OgbX5X43NYOCOggLBRuxfBODZogHIKmnT8fNcyL clU4UWMqyUMbGit7eY3OBvKadD/OW6
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Mar 08, 2022 at 02:11:28PM +0000, Andrew Cooper wrote:
> On 08/03/2022 13:49, Roger Pau Monne wrote:
> > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> > index 08016948ab..47d09d6cf1 100644
> > --- a/xen/arch/arm/xen.lds.S
> > +++ b/xen/arch/arm/xen.lds.S
> > @@ -30,9 +30,13 @@ SECTIONS
> >    _start = .;
> >    .text : {
> >          _stext = .;            /* Text section */
> > +       *(.text.header)
> > +
> > +       *(.text.cold .text.cold.*)
> > +       *(.text.unlikely .text.*_unlikely .text.unlikely.*)
> > +
> >         *(.text)
> > -       *(.text.cold)
> > -       *(.text.unlikely)
> > +
> 
> Most of this hunk wants to move into patch 2.  Patch 1 should only
> introduce .text.header.
> 
> Same for x86.  Can fix on commit.

The justification for doing it here is to better match the ordering
used by the default linker script from GNU ld. Obviously this also
benefits the following patch. Feel free to move, but I think it's also
fine to do it here.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.