[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86: also discard .fini_array in linker script


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 4 Mar 2022 10:22:54 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ULCRxBn4E4+Y6hs+knTA/7HPwqhGArPhRyYKyp8W8Qc=; b=BrJo8EdAdfb72pOnRHf/cqXLQXbv2JZXvqXaNasMw/arBh5LBsoCnWmyeq5mnX1dKXFT1Qu/3wpgV5+pIlhrp2quID4lMb2Z6ofAREfY+a/Bv75VLVyvInw5IsbYa0MmBnhHjRUl9+JqtTB7xp2d+C4KTfZ6P6oort8XQNECQIMURmvvnGBxwW5Rzc0cDMoI6yeMfcvb2IagkAkVTQJ29cUotSTrvcXio1z7V8Y8vqRkjqNqp2w0QwyeDBpvzF3nuagvWVv0CLvrETerRJcTxmF7Ve+JOb/RDJtjQxuc8VwCybLHJxp2RBX7ngj27TLXiItlifn5EImZWoHB+52QTA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bJEF9+lJQxdofce0EGFy7mw+Ew+AOgD0i4+KPJNzFyw2VS3fH0CKv7GU5HEp3sYyoUE1dXCgz53ffFrDck2HHikSrFegXYguARpUPOOv69yIiqD1wKjGsnVjr5c4n/xqL+Umca+nknGOwMEj1GdcL/tkpWOpu8J42zG7w1cTkjuHG+enVlW5xqdZIoOAufazta7/lI4NLNIQ1s9gZb+qNArBBi0FYb9x7S2s4wvL5wD9mLtK2LtDbTyYwc/NlRiMX+VFLbEZ2sipGM/BNG85jDA7zSjWfyV0wBHkZMYoc2aH6d7O3fen8xEfmnhglWMn1t/k3Ek1RCua9gX5s4G6ZQ==
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 04 Mar 2022 09:23:16 +0000
  • Ironport-data: A9a23:vMlueqBvZXWBoRVW/z/jw5YqxClBgxIJ4kV8jS/XYbTApGki1zZWz 2QdCmnSbvyLMGb0KtlzOY+19U9VuJKEn9FjQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Vh3tYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhsy ehSm5rzFD0sGf3Rg7k2bRAfNT1XaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGgWxh3JsSQJ4yY eIASDZtVjuQSCdzEUwKBagmtqSsn1fwJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc QpOoHNo9PVsshzwJjXgY/GmiGOFgwEyXZkNKegduByWl4Hq6kG/GkFRG1atd+canMMxQDUr0 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1sRiG2NPdXABb3nARBodtzxor6p5 iRspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD/I9sLumAlfBk1aa7onAMFh meJ42u9A7cJYROXgVJfOdrtW6zGM4C6fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z uuzwOPRk0QPCLClO3KPmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl kxRkGcCoLYjrRUr8Tm3V00=
  • Ironport-hdrordr: A9a23:RhTLxa6c9puosos6UwPXwSqBI+orL9Y04lQ7vn2ZFiY7TiXIra yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdhrNhQItKPTOWw1dASbsN0WKM+UyDJ8STzJ856U 4kSdkDNDSSNykKsS+Z2njALz9I+rDum8rJ9ITjJjVWPHlXgslbnnlE422gYytLrWd9dP4E/M 323Ls5m9PsQwVeUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZpzU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDl1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9kfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ1yHtycegA2w 3+CNUaqFh/dL5nUUtDPpZyfSKWMB26ffueChPaHbzYfJt3Tk4l7aSHpIkI2A==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Mar 04, 2022 at 10:17:22AM +0100, Jan Beulich wrote:
> On 04.03.2022 09:57, Roger Pau Monné wrote:
> > On Fri, Mar 04, 2022 at 08:49:39AM +0100, Jan Beulich wrote:
> >> This simply parallels .dtors. Both section types can reference
> >> .text.exit, which requires them to be discarded together with that one.
> >> Compilers, depending on their findings during the configure phase, may
> >> elect to use either model. While .{init,fini}_array look to be
> >> preferred, cross compilers apparently have this guessed, likely
> >> resulting in a fallback to .{c,d}tors. Hence we need to support both
> >> sets.
> > 
> > Do we also need to consider discarding .fini? Or that's guaranteed to
> > not be used by the compiler?
> 
> I'm not aware of it being used anymore; if it was used, we'd also need
> to deal with .init (which - logically, but not technically - would
> conflict with our own section of this same name in xen.efi).

We would realize if having the orphaned check (or like here would get
missing references.

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.