[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/tboot: adjust Kconfig default
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 3 Mar 2022 13:03:42 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f5c8wifocakWfoeiBYAtyleYLFOSYBjoeqa0zzoIY3k=; b=IJoiUJl0o2N7rN4/jTzmvIZakSUy/lLibPyzW9uicy1M8eYXI2P/FA00OjqWi9MquSx2dOyO9f5d9me8H0zol3/1j0opqFS8ZZTJ7OZ0eG9BAW2XQvYflsKBOPz3xS5hm2uEZKlDklRNeUdvCfa7eBvEf1fGUFs5geLn9vSiADGAFt0sG3TuCt0FYhcK6RIuzGoFLrlD2s4z7HajFjG4OXIKmB7acZLZAfX13HqDm2eFVc6BTev7fVm8RRzo46XWuAukEUWRdY+qUxzEisBp3aCAVYa1LSyxRAkHbzlTunnEIQSCB0Z/r74U0pRrK7D3Uwr5vXJW38B84lIXUHDFgw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kdniJOAQa7kRTej4QRfoBGD+XtOLpx0CfRWoc7nWpdyeSOswbpJLc+frjZmrI1iCwn7yyLEV4oIp2mP74sQDaxVTb/obCmFXuqPAHlnXlcO9+TVE8VgQxml0aKUhEN2qpdSlsfpusaykedc+8Q7M4v5a2bnYhzSuHb23eWtCLNEOmSO/YGCZ/dmgAnfxMfpi+tRCYZVYMDNIEpjAPNgP+wLzSEohQJTCYyQx+C1u05JhinTQuNGHFZu8i8Oxxid1E4Jos43ZPvh9WC5eq5fEskdmpO2oM6G4COY8HYyE2B3Ak2/g00nJvr3vNDtZGB9rDLrqZvg9HKFzr9OiUGCRQA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Mateusz Mówka <mateusz.mowka@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Lukasz Hawrylko <lukasz@xxxxxxxxxxx>
- Delivery-date: Thu, 03 Mar 2022 12:03:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03.03.2022 12:50, Daniel P. Smith wrote:
> On 3/3/22 04:49, Jan Beulich wrote:
>> We shouldn't include unsupported code by default, with not even a means
>> for its building to be disabled. Convert the dependency from merely
>> affecting the prompt's visibility to a real one.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> We could of course go further and make the default also account for
>> DEBUG, as is done elsewhere.
>
> As in you would like to adjust the default based on whether DEBUG is on
> or not? I guess my question is what motivation is there to adjust this
> selection if DEBUG is enabled or disabled?
This is to have functionality enabled unless overridden in debug builds.
>> --- a/xen/arch/x86/Kconfig
>> +++ b/xen/arch/x86/Kconfig
>> @@ -193,14 +193,15 @@ config HVM_FEP
>> If unsure, say N.
>>
>> config TBOOT
>> - bool "Xen tboot support (UNSUPPORTED)" if UNSUPPORTED
>> - default y if !PV_SHIM_EXCLUSIVE
>> + bool "Xen tboot support (UNSUPPORTED)"
>> + depends on UNSUPPORTED
>> + default !PV_SHIM_EXCLUSIVE
>> select CRYPTO
>> ---help---
>> Allows support for Trusted Boot using the Intel(R) Trusted Execution
>> Technology (TXT)
>>
>> - If unsure, say Y.
>> + If unsure, stay with the default.
>>
>> choice
>> prompt "Alignment of Xen image"
>>
>
> Outside of the debug question, I think the proposed change is good.
>
> Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxx>
Thanks. I guess there's an 'o' missing though in the email address?
Jan
|
