[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC (take two)
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 1 Mar 2022 14:56:52 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WMo1hLmk0qH/EB55HU7/OnIZLjY9f/TCFdkVU0IOvuU=; b=f6c4cWZ7kxk3mouMoNBvNzMGgtpQn4+zrmqDa+sUYSF2PS01GpMdijtX9BvkqGAESDnxo75SVmPsMvrcEB/OJz01PY6O/qQuryya36syQy5TIV4GbvoVRzWqNJ8xVOFMYgNbE6N+VR26joadrCKJAllz+8u7L8mhTwHf/9yoi14nJ6bP2i9v+jSAUztqzaM/C30epm8oJL7DJJTdCYlEc7Pjr7122T/roOYn9nbFnUahcUrIZRtJ2AjIHZgGd26AgoSo4uNJjAWb+3KhN0wK5UhFcSgsBiYi2diqh/FHIkpofx0proXf7LklYHP9poq3R1f7o5JpN5HOcD6lSQSo1w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dwZ8ToyfGnaSkHm+Ya4iI5RNUMkode7abK0XCsk+RnujlwBVsJ/B8fxMP2eH3Smr3SmVkrEhYxjA4GK9PISGC3yHWTUXoF0HsJlJ/SbicIT5zX33+1hXKtSNmQZ9UdoxDw7dZGPrNmfr9WR5tGqTmPjOTccWWGODc3hpwSnLMCn/bTIYEo4Y0W4ITvQZddXT2XoJowOxfKM5y6ugpvzMkWjTd3alHDaFOEoifLN+LMWApIsFaCwC7harSOXfxYMB9YPYlCYiPMdpfo3shit22Iqp7M/2B5NTdVnedELZ6G8bYgreNQ/8JhPzgoXsbj+D181y2mq42AkPv4z1ajjTqw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 01 Mar 2022 14:57:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYLIsbZnt9ucibr0G+vW8JMwB0sqyqoBUA
- Thread-topic: [PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC (take two)
Hi Julien,
> On 28 Feb 2022, at 10:08, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Commit 13c03002c5df ("xen/arm64: head: Mark the end of subroutines
> with ENDPROC") intended to mark all the subroutines with ENDPROC.
>
> Unfortunately, I missed fail(), switch_ttbr() and init_uart(). Add
> ENDPROC for the benefits of static analysis tools and the reader.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/arm64/head.S | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 314b800b3f8e..66d862fc8137 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -800,6 +800,7 @@ ENDPROC(launch)
> fail: PRINT("- Boot failed -\r\n")
> 1: wfe
> b 1b
> +ENDPROC(fail)
>
> GLOBAL(_end_boot)
>
> @@ -830,6 +831,7 @@ ENTRY(switch_ttbr)
> isb
>
> ret
> +ENDPROC(switch_ttbr)
>
> #ifdef CONFIG_EARLY_PRINTK
> /*
> @@ -847,6 +849,7 @@ init_uart:
> #endif
> PRINT("- UART enabled -\r\n")
> ret
> +ENDPROC(init_uart)
>
> /* Print early debug messages.
> * x0: Nul-terminated string to print.
> --
> 2.32.0
>
|
