[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86/time: use fake read_tsc()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Tue, 1 Mar 2022 14:41:20 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cYvcvTlc7QjuOAplFLIHIwXoyIbJYXN1vmW4gf/g2bc=; b=agmSLJzK36lQbCJmCps+t/Tjn1dfh2BtCdK+co+rY/JGXuswbHXmee700g637Yi+WzGSeY7f0pMUpNJjqO1o0ZyCbUrTuWtHd6HMslmWWo8KCjRVx1S+s881of971Nd32bYUFIWFR4GXILugnHOUFiiZTQOoY7YxuC8li7KGj6kbUq5V3H4LOL30Vx9fNzEApkOgnmIJTfTREyXIqqhcEpvCM8/shRv/5pH/20CAi1Jq6/CYsKEHZtRgIq0G/ZpqprCEQTXqXehuLpkkKBKIee1NrsGiFjsTwIlzb3aXa8fVQtlszl9HWT/RDcgwYM8mc+jHNMxXumU/yruCrZh7/w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FfgK09031yvhwFnIOkYdYvfK/I7IoMfxVxSlRsKCy96zx9/xFQXt98HzrTCcMOeZ1naDOwLrMARbZ1BH/xt0Lo/hi9ISkHvGG70doUBgOBaRgbEBePbESOggD1q3ecm96saycg2XI+hsgaHa+jqsuuZYQinfibUfOSskqdbgA9nAT04/swulkMdcRX+mDepL/4Vtig9bH8O/q034WqPf7uDChvIg4cFLWzDjfwuzTRHoAALRDLY9lnel5azW0h74HP9TB3tjW6Ru/ZQDJZiSJxWePxFY/6edXYX0cRKXwQq2KRlKU5c9GX5MnGpjHtLsGRX+cF4SyV605Y+PRszRxA==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 01 Mar 2022 14:41:34 +0000
- Ironport-data: A9a23:qIwR8K16Mt4cKl+dF/bD5c5xkn2cJEfYwER7XKvMYLTBsI5bpzQHz TdNCmiAaamIYzf1f991aozi9E9VsMWDn9FrHANrpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tUw2IDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1xu76UdFkgPJaShcUhUCECPXljZrZ/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiDP ZBFNWYzBPjGSyxCHHgsDao/pcrymSmufTAD+WiNo4NitgA/yyQuieOwYbI5YOeiVchT20qVu G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoNEJWo+/gsh0ecrkQRAhALUVqwodGil1WzHdlYL iQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4L+MYzDzTw6jvvRu4Oms8FBAZdYc9jZpjLdA17 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoCtQVnNL ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT1sTA3Dt4ade51q2VtW lBew6ByC8hUUPmweNSlGrllIV1Qz6/t3MfgqVBuBYI90D+m5mSue4tdiBknehs3aplfJ2OwO RaC0e+02HO1FCHxBUOQS9jsY/nGMIC6TYi1PhwqRoAmjmdNmP+vo3g1OB/4M5HFm0kwi6AvU ap3gu73ZUv2/Z9PlWLsL89EiOdD7nlnmQv7GMCqpzz6gOH2TCPEFt843K6mM7lRAFWs+16Or b6y9qKiln1ibQEJSnKPoN5LcAtTdiBT6FKfg5U/S9Nv6zFOQQkJI/TQ3akga8pimaFUnf3P5 XazRglTz1+XuJENAV7ihqxLAF83YatCkA==
- Ironport-hdrordr: A9a23:q53S1qMSvcrII8BcT2/155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjzjSWE9Qr4WBkb6LW90DHpewKSyXcH2/hsAV7EZniphILIFvAv0WKG+VPd8kLFh5dgPM tbAstD4ZjLfCJHZKXBkUiF+rQbsaG6GcmT7I+0pRYMcegpUdAa0+4QMHfBLqQcfngjOXNNLu v72iMxnUvGRZ14VLXYOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LPErXoBerR8bMRiA0HkAgMbzaFBOO gg5RPpi7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4bkWUzxjIdLH47JlOz1GnnKp gbMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Tol4QsJYmD5VU7e XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+83JwloOWxPJAYxpo7n5 rMFFteqG4pYkrrTdaD2ZVamyq9NllVnQ6dvf22y6IJyIEUHoCbQhFrYGpe5vednw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYLVxVKor9YtEUbkuWag9T3yUcNqyqf+CAgAAS0gCAAAbHAIAAAKIA
- Thread-topic: [PATCH 1/2] x86/time: use fake read_tsc()
On 01/03/2022 14:39, Andrew Cooper wrote:
> On 01/03/2022 14:14, Jan Beulich wrote:
>> On 01.03.2022 14:07, Andrew Cooper wrote:
>>> On 01/03/2022 11:05, Jan Beulich wrote:
>>> That said... what's wrong a plain NULL? I can't see any need for a
>>> magic constant here.
>> Are you fancying an XSA for a call through NULL in PV guest context?
> Why do you think that a risk? Only non-NULL function pointers are
> followed, and altcall resolves safely if the pointer is still NULL.
>
> And on that subject, don't we not hit the altcall's BUG_ON() for
> exceeding disp32?
don't we hit*
~Andrew
|
