[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86/time: add CF-clobber annotations
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Tue, 1 Mar 2022 13:18:26 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FNUCsQ/3JDb57Sl6fkwHLvMucRLmH2WJUthE75WdN54=; b=WR1gMQx4NxDqrnz91k3mWBjdytfYzkR9ALHi5hTqEnyNMpV0ZyQ2UJF7kI4s+j+hhWczqeW4tAjUlAGWaCuSUsNADtPZcAWd/vQRxRmpUJ2o0OzBnhmlqJ14Y3a5uGITsL5d7crWPSGfXdZDaBHynyRYmBENbXG60Gtue0e/3Y4sRA2rSUdHmNvUsnuUFcweRUwuVLjOm12CjeWhR5as7nR8u9g/Bqg4nikJ9zQChEL2YsJ+Zr6wDCd5DIjeEkBhOgWVHLL0jgLeozx6BIG0IPecmCLKXMf4mUE+qOz7oXu6Pba3e/aUlUJ21kbkBHIYztXVuRsViqwOVPG6LA0wQQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h7oilectNqtwr/dToN49LEL3WxFctig1P3v8x0BEXw6i5zAM65ynwBwWLwpiNBwCRiNoOZUpo7i3J9Pu+aanLT8QzAmFUB+TKscGi6xOFVC5GY6EzGf2kwHAQbKk2LLEFO1TbzPY7Qr+CF7EnayXVQwKDEFD4OnDlitZSuOsL28whh2+AVurANR367pCj/XymYuz/vwZrl7JqUXqybmFlrYslcN/vXCxsI7NU+Csw9zV36G9yAG9+uEmL2gfmWr89Q7Clq5pWKe75ARBje2zBvClz3frVBmoTOmkv3eFa29bjBKQ++9bO8DG6hLXFuucXddHvktsDOx6qnxytNudtg==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 01 Mar 2022 13:18:38 +0000
- Ironport-data: A9a23:quNuG63V3Ug/w92StfbD5c5xkn2cJEfYwER7XKvMYLTBsI5bp2MHm jMWXG/Saa2OZ2L0LYx3PNm38h8EvMOHyd5rTgFkpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tUw2IDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1ilru9SgRxN5aSwukMfgVSAQdlZ51JreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiDP ZNHN2s2BPjGSwYMOHsxC5QZp9zyrGjgUiVyqULM+ZNitgA/yyQuieOwYbI5YOeiWsF9jkue4 GXc8AzREhwccdCS1zeB2natnfPU2zP2XpoIE7+1/eIsh0ecrkQRAhALUVqwodGil1WzHdlYL iQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4PM4d5QKOkqPvvVyUF0UYRCxnc4YWu5pjLdA17 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoCtQVnNL ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT1sTA3Dt4ade51q2VtW lBew6ByC8hUUPmweNSlGrllIV1Qz6/t3MfgqVBuBYI90D+m5mSue4tdiBknehs3aplfJ2OwO RaC0e+02HO1FCHxBUOQS9jsY/nGMIC6TYi1PhwqRoAmjmdNmP+vo3g1OB/4M5HFm0kwi6AvU ap3gu73ZUv2/Z9PlWLsL89EiOdD7nlnmQv7GMCqpzz6gOH2TCPEFt843K6mM7lRAFWs+16Or b6y9qKiln1ibQEJSnKPoN5LcAtTdiBT6FKfg5U/S9Nv6zFOQQkJI/TQ3akga8pimaFUnf3P5 XazRglTz1+XuJENAV/ihqxLAF83YatCkA==
- Ironport-hdrordr: A9a23:OQJ0jamiaf2AxCJeJBWsCqRTQPTpDfOMimdD5ihNYBxZY6Wkfp +V8sjzhCWatN9OYh0dcIi7SdW9qXO1z+8Q3WGIVY3SEjUOy1HYU72KirGSggEIeheOudK1sJ 0AT0EQMqyJMbEXt7eZ3OD8Kadc/DDlytHpuQ699QYXcegCUcgJhG0Vanf5LqQ1fng9OXNQLu vH2iMtnUvGRZ1jVLXDOpBzZZmkmzSkruOCXTc2QzocrCWehzKh77D3VzKC2A0Fbj9JybA+tU DYjg3Q/MyYwrKG4y6Z81WWw4VdmdPnxNcGLteLkNIpJjLljRvtTJh9WoeFoCs+rIiUmRQXeZ j30lId1vZImjTsl1KO0F3QMs7boW8TAkrZuBulaL3Y0JTErXwBepF8bMliA2XkAgIbzaBBOe Rwrj+kXtNsfGD9dG6W3am5azh60kWzunYsiugVkjhWVpYfcqZYqcgF8FpSC4poJlOx1GkLKp gnMCjn3occTbpaVQGvgkB/hNi3GngjFBaPRUYP/sSTzjhNhXh8i08V3tYWkHsM/I80D8As3Z WJDo140LVVCsMGZ6N0A+kMBcOxF2zWWBrJdGafO07uGq0LM2/E75T3/LI27ue3f4Fg9up+pL 3RFFdD8WIicUPnDsODmJVN7xDWWW24GS/gz8lPjqIJ84EUhICbRxFrZGpe5vdI+c9vcPEzc8 zDTK5rPw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYLVxwam4XOlcoM0qksn/nZK0dPqyqgvIA
- Thread-topic: [PATCH 2/2] x86/time: add CF-clobber annotations
On 01/03/2022 11:06, Jan Beulich wrote:
> With bed9ae54df44 ("x86/time: switch platform timer hooks to altcall")
> in place we can further arrange for ENDBR removal from the functions no
> longer subject to indirect calls. Note that plt_tsc is left untouched,
> for not holding any pointer eligible for ENDBR removal.
I'd be tempted to include it, for consistency sake alone.
It is less likely to go wrong in the future if another hook is introduced.
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
With the commit message, I'm not not certain if this is linked to the
previous patch.
Overall it looks fine, but I'd like to get clarity on this point.
> ---
> I did consider converting most of the plt_* to const (plt_hpet and
> plt_pmtimer cannot be converted), but this would entail quite a few
> further changes.
It's all initdata. const is not terribly interesting, especially if it
is invasive and incomplete to do.
~Andrew
|
