[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] xen/vpci: msix: move read/write call to MSI-X PBA entry to arch file
- To: Rahul Singh <rahul.singh@xxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 25 Feb 2022 09:20:27 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PUtxugdevG2Vz087BTXIdqD2zU1rmzcIyP5uJoil3Lc=; b=JCCPnr9wgP8eOmZE5NFLU1+IW3mjTmT7bUoU1Fg6BqunH+XS2/k9fJb0j/SxOOMW7xrVvGgg+udOPFmMLCbEndVH0aDE47y5UkKkWC/W0L6BFFQMaEo7GlcXYaoA/gDydsQZ0akPLDojutX6OMpuFUSvuOC3w/AnQ6VY+eEFbmpD0C/YlK7cAYDK5uqzIJYaxZK3vyAJdhJnKxGDCbTMh6g3ldeZtvnl5iTKVY8GMNeVZkTSSoR4BG9YRbWVd5n+jNIbDJEy21cHn/xE6cHlT6k8DSb/RmOiKmh+6TAFKNuKneF0ysJVhmZ8pCAQtrNUoJmqNEj7sljOF9QAxbNA+Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KlHJm6PrQmzOzLS2lcJIzT8FCA42BZ1e20hF30AkwqOLPkTXoLnY/m0XKLx7HnEGWAfF5cX3nHj7RKzJrrhHNQ22tLBmF1QPE+hxTrfLJfSk2rDOlG2N3bF27vlYuSRF9wh0DRUs9GoxOXSxmksGSFT/LZLd82K+bWlInm3TSC736UWSP8cLpOBmycTZnXMu9M2KdOiC5hmoDxn4COhKJgd/0W4bFHQvriKM5ku6tG6HzGVEjzFs0c+7q9L1KQpGzs448ZO/UTot1rnrvB51lg/OWsxEz1Y9OdjaMXEIX4Sck+WB61gfAL6R908vkgkMj/ltnPH5NpXUd61Lb4aNlw==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <bertrand.marquis@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 25 Feb 2022 08:20:49 +0000
- Ironport-data: A9a23:Q3N5mqvwZjDFdxdQXHaJGT+8refnVJFeMUV32f8akzHdYApBsoF/q tZmKWrXa/aPYDb2eoxyPI22/B8OscSEyNVmSlNkrn8xEihE+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1nX5 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi80DqKPodsPTyJ6UABFB/Ya26DeCHGW5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yj7UF7A+SI3rSKTW/95Imjw3g6iiGN6AO 5tGNGYxN3wsZTVFK2UUOs46ptyv2D7vaDt2pnDIuIEOtj27IAtZj+G2bYu9lsaxbcdfk1ucp 2nG13/kGRxcP9uaoRKa9lq8i+mJmjn0MKoYGaek7PdsjBuWz3YKFRwNfVKhpL+yjUvWc8hWK 1EQvDEvq6cy3EWxS5/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6cLqScCj wHT2YmzXHo27ePTGSn1GqqoQS2aJBgablY9dzM/b0gk2OO4/KIslzvGZ4M2eEKqteHdFTb1y jGMiSExgbQPkMIGv5mGEUD7byGE/caQEFNsjunDdif8t14iOtb5D2C9wQWDtZ59wJClok5tV ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFRzxqhZPnqgKuVmSwXuF1O5eKFcFh 2eJ5GtsCGd7ZifCUEOOS9vZ5z4W5abhD8/5cfvfc8BDZJN8HCfeon0zOhLJgz21yBB0+U3aB Xt9WZz9ZZr9If46pAdaus9HieN7rszA7Tm7qW/HI+SPjuPFOS/9pUYtO1qSdOEphJ5oUy2Om +uzw/Cikk0FOMWnO3G/2ddKcTgicChqbbir+pc/XrPSfWJb9JQJVqa5LUUJINc+wcy4V47go xmAZ6Ov4AGn1C2fdF7TMSgLhXGGdc8XkE/X9BcEZD6A83MifZyu/OEYcZ42dqMg7+tt0bh/S PxtRilKKq4npujvk9jFUaTAkQ==
- Ironport-hdrordr: A9a23:qY3l5qkJgDKlF/FEttAgBRvdcFHpDfPCimdD5ihNYBxZY6Wkfp +V8sjzhCWatN9OYh0dcLC7WJVpQRvnhPhICK0qTMqftWjdyRGVxeRZjLcKrAeQfhEWmtQtsZ uINpIOdOEYbmIK/PoSgjPIa+rIqePvmMvD6Ja8vhVQpENRGtpdBm9Ce3im+yZNNXB77PQCZf 2hDp0tnUveRZ1bVLXyOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx mOryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idgrP D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT1vDRdXYfMY5slIhZehzW5w4Lp9dnyp 9G2Gqfqt5+EQ7AtD6V3amGazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu UGNrCR2B9vSyLaU5nlhBgu/DT1NU5DXStuA3Jy9/B96gIm0kyQlCAjtY4idnRpzuNId3AL3Z WADk1SrsA8ciYnV9MMOA4/e7rENoXse2O7DIvAGyWvKEk4U0i93qIfpo9FoN2XRA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Feb 15, 2022 at 03:25:18PM +0000, Rahul Singh wrote:
> {read,write}{l,q} function argument is different for ARM and x86.
> ARM {read,wrie}(l,q} function argument is pointer whereas X86
> {read,wrie}(l,q} function argument is address itself.
>
> {read,write}{l,q} is only used in common file to access the MSI-X PBA
> structure. To avoid impacting other x86 code and to make the code common
> move the read/write call to MSI-X PBA to arch specific file.
I think we agreed where going to unify {read,write}{l,q} so they could
be used in arch-agnostic code?
Thanks, Roger.
|
