[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/arm: Rename psr_mode_is_32bit to regs_mode_is_32bit





On 22/02/2022 07:07, Michal Orzel wrote:
Hi Julien,

Hi Michal,

On 21.02.2022 16:58, Julien Grall wrote:
Hi Michal,

On 21/02/2022 10:59, Michal Orzel wrote:
Following a discussion [1] it seems like that renaming work has
been forgotten.

This is in my todo list of clean-up I need to do for Xen. But I haven't yet had 
a chance to look at it. Thank you for taking a look!

Perform renaming of psr_mode_is_32bit to
regs_mode_is_32bit as the function no longer takes psr parameter.

If we modify psr_mode_is_32bit(), then we should also modify psr_mode_is_user() 
because they have the same prototype and we should keep the naming consistent.

Ok, I agree. Do you think this should be done in a separate patch?

I am fine either way so long the two changes are committed together.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.