[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] github: add workflow to run Coverity scans


  • To: Andrew Cooper <amc96@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 18 Feb 2022 14:36:01 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G/5CpKoyKCE/Gsh5aSSZpTE6RwlvYPQR20z+RqO1Gfc=; b=UWB5vqJS9y7ePfu9xmu7ujPkCDzWVvyy0+JSpJO2YO6DyfpSd7eUAtnQ7Sxy6Am9UFDQ5b8Wr1Ykt4CFD4CxlmduprwBf8DRXWyH+ImtYg0zJJ3+dAY6Mrd9CHkcq6A9HpQ7m5O2k52VMxwIEk3X1yHrnQVWDFHqPoq6SF+IUBI8Gj2IARMty7/tk4G774KokLwakmfwz7v2X3Zl+GCl2LkQlGxGjIfjtNDBoSP8EwuedJsZWVQxSQ0fi17STK5mRmMPJHbyUD+GcODhzUIjEYE+nXqsZWj1m1KNi8LcftMsow/xfmJYW69Ujb4oYPRe8e7z5ST6Jr4COGmYv4i7/Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QXvcwjzvg23FCWONa9bJI007oRLCTehjQlvqZLcgGMSO0G+XMKvNvSf4RHzjF6mBDb1TB29UCJWgf0RCxg6YxyCwoI+BbPOPqU9CjFYkKY6hxdFF4KND3h2QG3xsMB1lW4uhlbQSlTFqL2W1UnESkHMtRHpHY4Hc+s4vJPhlNMGkdkzIX1LuWhqBsZ5M9C+2NgvJ127nM230CbqSjiiRo8eFPVe831RZ8eAicQ0u98H7aVX51kXVXdKiFTrD9B56WI2j4wCeJMIh0uTCKKZTF7B8DrUXh2DJUGrJ8eWOjQnJoD58Aum+Hw/YAyeq5vbpmj+wcrYh8CqtV+FLxPjH2w==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 18 Feb 2022 13:36:18 +0000
  • Ironport-data: A9a23:fFQZFKIiC7ECzOMtFE+RHpUlxSXFcZb7ZxGr2PjKsXjdYENSg2dSy 2dJXWGFOPyJY2P9LYp3aN+28hhSvcXXxoNlS1FlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc42YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 Otxma7zDjd1BJaSotYhaj9hFSV4OqITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gls15oXQ6yFD yYfQWNBYSvubCdyAwsGE4wyubrzgCKiMBQN/Tp5ooJoujOOnWSdyoPFMsfRe9GMbdVYmACfv G2u13/iHhgQOdibyDyE2nGhnOnCmWX8Qo16PKK83u5nhhuU3GN7IBQTXgrlieKjgUD4Xd9DQ 2QE9yxroaUs+UiDStjmQwb+sHOCpgQbWddbD6s98g7l4qje7hudB2MEZiVcc9Fgv8gzLQHGz XfQwYmvX2Y29uTIFzTNrd94sA9eJwArEUMwJmg0ETE+vePRnLgVtxTLSNFsRfvdYsLOJRn8x DWDrS4bjroVjNIW26jTwW0rkw5AtbCSEFdru1y/snaNq1ogOdX7P9DABU3zsK4YRLt1WGVtq 5TtdyK2yOkVRa+AmyWWKAnmNOH4vq3VWNEwbLMGInXAy9hP0yLyFWyzyGsnTKuMDiriUWa4C KM0kVkMjKK/xFPwMcdKj3uZUqzGN5TIG9X/TezzZdFTeJV3fwLv1HgwORPJhTy1wRRyyPtX1 XKnnSCEVCdy5UNPlmfeegvg+eVzmnBWKZ37HvgXMChLIZLBPSXIGN/pwXOFb/wj7bPsnekm2 403Cid+8D0GCLeWSnCOqeY7dAlWRVBmVcGeg5EGLYarf1s5cFzN/teMmNvNjaQ+xP8L/goJl 1ngMnJlJK3X3yOfclzSMig5AF4tNL4mxU8G0eUXFQ/A81AoYJq17bdZcJ0yfLI98/dkw+IyR P4AE/hsyNwVItgb01zxtaXAkbE=
  • Ironport-hdrordr: A9a23:gd1tFKPwnatXh8BcT1n155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjztSWUtN4QMEtQ/uxoHJPwO080kqQFnLX5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79 YdT0EcMqyAMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt9dBmxCe2Cm+yNNNW177c1TLu vi2iMLnUvqRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUID/Z4StU z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF+nMifrHIR1P XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSv2OwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze Ziw3+Zn4A/N2KPoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFpLA BXNrCd2B9qSyLYU5iA1VMfguBEH05DUitue3Jy+/B8iFNt7TVEJ0hx/r1pop5PzuN4d3B+3Z W2Dk1frsA7ciYnV9MMOA4/e7rENoXse2OEDIvAGyWuKEk4U0i93qIfpo9Fo92XRA==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Feb 18, 2022 at 12:23:47PM +0000, Andrew Cooper wrote:
> On 18/02/2022 12:21, Andrew Cooper wrote:
> > On 18/02/2022 12:00, Roger Pau Monne wrote:
> >> Add a workflow that performs a build like it's done by osstest
> >> Coverity flight and uploads the result to Coverity for analysis. The
> >> build process is exactly the same as the one currently used in
> >> osstest, and it's also run at the same time (bi-weekly).
> >>
> >> This has one big benefit over using osstest: we no longer have to care
> >> about keeping the Coverity tools up to date in osstest.
> >>
> >> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> >> ---
> >>  .github/workflows/coverity.yml | 35 ++++++++++++++++++++++++++++++++++
> >>  1 file changed, 35 insertions(+)
> >>  create mode 100644 .github/workflows/coverity.yml
> >>
> >> diff --git a/.github/workflows/coverity.yml 
> >> b/.github/workflows/coverity.yml
> >> new file mode 100644
> >> index 0000000000..12fc9c782b
> >> --- /dev/null
> >> +++ b/.github/workflows/coverity.yml
> >> @@ -0,0 +1,35 @@
> >> +name: Coverity Scan
> >> +
> >> +# We only want to test official release code, not every pull request.
> >> +on:
> >> +  schedule:
> >> +    - cron: '18 9 * * WED,SUN' # Bi-weekly at 9:18 UTC
> >> +
> >> +jobs:
> >> +  coverity:
> >> +    runs-on: ubuntu-latest
> >> +    steps:
> >> +    - name: Install build dependencies
> >> +      run: |
> >> +        sudo apt-get install -y wget git bcc bin86 gawk bridge-utils \
> >> +          iproute2 libcurl4-openssl-dev bzip2 libpci-dev build-essential \
> >> +          make gcc libc6-dev libc6-dev-i386 linux-libc-dev zlib1g-dev \
> >> +          libncurses5-dev patch libvncserver-dev libssl-dev libsdl-dev 
> >> iasl \
> >> +          libbz2-dev e2fslibs-dev git-core uuid-dev ocaml libx11-dev \
> >> +          ocaml-findlib xz-utils gettext libyajl-dev libpixman-1-dev \
> >> +          libaio-dev libfdt-dev cabextract libglib2.0-dev autoconf 
> >> automake \
> >> +          libtool libfuse-dev liblzma-dev ninja-build \
> >> +          kpartx python3-dev python3-pip golang python-dev libsystemd-dev
> > We dropped gettext as a dependency a few releases ago, and we don't need
> > python3-pip either.  Can fix on commit.
> >
> >> +    - uses: actions/checkout@v2
> > I think we want
> >
> > - uses: actions/checkout@v2
> >   with:
> >     ref: staging
> >
> > Can also fix on commit.
> >
> > Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> (mainly because I
> > can see that Coverity has done the right thing with this.)
> >
> >> +    - name: Configure Xen
> >> +      run: |
> >> +        ./configure
> 
> On second thoughts, we can probably --disable-docs here, because it's
> just wasted processing time when all we care about is the C.

We do not build the docs already, because the build command is `make
xen tools`.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.