[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF metadata
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 17 Feb 2022 17:16:40 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xek/oQqGq7nBXNMK/qReZzo6SCj9YW6gLqIfCeyunag=; b=BAFTlgzt7g1s6F442iZRQnXG4tqPddZXNaYzueaM/KFLMsy27AuI35fkoUpaISp2xcSWXEuKWi8zJuxigAUVLTCEUkPw6pK5lo2iYEnNkejAK1LXMEhuGMh5XnDt9aE3nyEQ2+yniRRbMJbCz3s0nL+n6WXiLnXYGjYqMc6N5Lb5JWtlzXkysa6W/uNSzZV8nLS21s7bi3bvxumrGIjFazraotagrdMI0QPzkoJ9TIJWXG19Sg9zrZSV2CxfrakZLESmaM5fHz0Xr01ADr8DW5Lkn4KMSm5Gs5IQaOmRUNXIKvTsL3P74vaZiJrNmDIEN2Jod9l/sTKYXDSN91Xlpw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jN3vABOdpM9WXFlMLwK5aRHPkp8OWofqxxURH+1GQ/pIJ0DwdBfdKivYmExfqD5/9Hg+11p8LDO7GROYGjy98ceWUkksu2R7q59+zMtw+6qx28T1R+SQ7pyna8X4JCfmA32BJg24DBmZQwPkgJBPLmHCVHQBX9sbfaFfzCBGjPruTuamiiPS+AIflh0WWT4DQLMvhA+rgV3DbWCCNeaC1cTeG9iX4wzjAPftEvdaQPjKbxbQdkyUVvnNjs4DbMEzhUfXNnF7coJwEX8GhdXeK/AKf0kd5rJXvFsq3Sffq1slFOPbnMg8Mi+m/Pbh/defsqbkDyBBjtuDVLrWkNb6mg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 17 Feb 2022 16:16:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.02.2022 17:06, Andrew Cooper wrote:
> On 17/02/2022 14:48, Jan Beulich wrote:
>> On 17.02.2022 13:06, Andrew Cooper wrote:
>>> On 17/02/2022 10:42, Jan Beulich wrote:
>>>> On 17.02.2022 11:01, Andrew Cooper wrote:
>>>>> --- a/xen/arch/x86/xen.lds.S
>>>>> +++ b/xen/arch/x86/xen.lds.S
>>>>> @@ -87,6 +87,7 @@ SECTIONS
>>>>> *(.text.unlikely)
>>>>> *(.fixup)
>>>>> *(.text.kexec)
>>>>> + kexec_reloc_end = .;
>>>> Does this maybe want aligning on a 4- or even 8-byte boundary? If
>>>> so, imo preferably not here, but by adding a trailing .align in the
>>>> .S file.
>>> There's no special need for it to be aligned, and it is anyway as the
>>> stack is the last object in it.
>> You mean it anyway would be, if the stack was aligned? Or am I to imply
>> that you've amended the patch to add alignment there?
>
> I have aligned reloc_stack stack because that's a no-brainer.
With this ...
> With that suitably aligned, kexec_reloc_end becomes aligned naturally
> (because reloc_stack is the final object), and I don't think there's
> much point putting anything explicit in the linker script.
... I certainly agree with this.
Jan
|
