[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/5] xen/vioapic: add support for the extended destination ID field


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 16 Feb 2022 16:54:10 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9//Ze51g2rWtuH/+mWD56wUakSQCmxjrzIMfoLr+5P4=; b=A3C2bp3MWSKRTUSFG61cjhRq+ORt1+02escdLYEDF8CwwGVwAsLndtSYbXWG/sNOUXnabqaTXdkjFRme5hXHEhTK0Mi2bh832SxtJPNNk5Ai602eRqx4HJMOWxfnr3Rb21hOKLqTDimfsqoxhkXfDCgPW4OmQVk2ThoFhXzkl1/0J4KWxdMLaSfWrH64PwU5/tatk6myM8a6teIE0gnuCm0dud0ZyYN0GgfTLS1fRzjcjIOJ69VIg94WEzb0K6XAlK6Xp3Fb81W40C2gtEo3A4G5DVbs0dgijNzCt8uAaPG9fQEfdWXJHnttrIHOPswEw+6K0wl5gbjy67fuXZGZ+Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BVN8kyt2RRsnLRejM8X3wBzqY+XOH181au5PhNARb2KwNLnLhbZ/+cWrQJEjN/WcdiPpAV3o3e1QC3bCir9gi/t3yK8M8DqM1OxPjxR0LMO74UpzrdEUi2btZR0LSjeGKS+QyeydZPhm2FveHyln1CVgxtMhNX1suWL3bZLYz2lrF28G3pFi0ANsYq4NEkWincq+6zJrZI+I8wKFUCKHOjmRKy3QEt7jlJ4VHUZyt+piIsA8Ard615jhYXtMSbrocDj4eqiQaoPpppB+ceDvr/W5qseTvwsW2F0Dpp7w23TKF/gE3LG6dd0IJLJ5wckMuWZJG7Akwh/4vLeG9OoQXQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: dwmw2@xxxxxxxxxxxxx, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 16 Feb 2022 15:54:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16.02.2022 11:30, Roger Pau Monne wrote:
> Such field uses bits 55:48, but for the purposes the register will be
> used use bits 55:49 instead. Bit 48 is used to signal an RTE entry is
> in remappable format which is not supported by the vIO-APIC.

Nit: The first sentence looks to have some stray words.

> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -527,6 +527,14 @@
>   */
>  #define LIBXL_HAVE_MAX_GRANT_VERSION 1
>  
> +/*
> + * LIBXL_HAVE_X86_EXT_DEST_ID indicates the toolstack can signal to the
> + * hypervisor whether the domain wants to use the extended destination ID 
> mode
> + * for interrupt messages. This is done by setting the 
> libxl_domain_build_info
> + * arch_x86.ext_dest_id field.
> + */
> +#define LIBXL_HAVE_X86_EST_DEST_ID 1

Did you mean LIBXL_HAVE_X86_EXT_DEST_ID, as the comment has it?

> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -648,6 +648,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
>                                 ("vuart", libxl_vuart_type),
>                                ])),
>      ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
> +                               ("ext_dest_id", libxl_defbool),

Let's hope there's not going to appear any other meaning of "dest ID".
I would have suggested to add "apic" to the name, but this would get
it a little longish for my taste.

> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -782,6 +782,7 @@ static struct domain *__init create_dom0(const module_t 
> *image,
>  
>          dom0_cfg.arch.emulation_flags |=
>              XEN_X86_EMU_LAPIC | XEN_X86_EMU_IOAPIC | XEN_X86_EMU_VPCI;
> +        dom0_cfg.arch.misc_flags |= XEN_X86_EXT_DEST_ID;
>      }

Without any way to suppress this?

> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -38,7 +38,7 @@
>  #include "hvm/save.h"
>  #include "memory.h"
>  
> -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
> +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015

I'm struggling to figure which binary incompatible change in here
requires this bumping. Does this perhaps belong in a later patch?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.