[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 02/11] xen: introduce CDF_directmap



(+ Jan)

Hi Penny,

I am CCing Jan to give him a chance to...

On 14/02/2022 03:19, Penny Zheng wrote:
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index cfb0b47f13..24eb4cc7d3 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -31,6 +31,10 @@ void arch_get_domain_info(const struct domain *d,
  /* CDF_* constant. Internal flags for domain creation. */
  /* Is this a privileged domain? */
  #define CDF_privileged           (1U << 0)
+#ifdef CONFIG_ARM
+/* Should domain memory be directly mapped? */
+#define CDF_directmap            (1U << 1)
+#endif

... comment on this approach. I would be happy to switch to an ASSERT() if that's preferred.

Please note that as you modify x86 code (even it is a couple of lines) you should technically CC the x86 maintainers. Similarly the changes in include/xen/domain.h should have the REST CCed.

We have a script that will find the proper correct CC for each patch (see scripts/add_maintainers.pl). The workflow is written down in the script itself.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.