[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 15 Feb 2022 17:18:59 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ioi/htouuhSZmkaVTDshvz4D/moGu2rMwb80FkDpNE8=; b=h842nNtrgcO0bEWqlFAHyUdzvWHjxkm3kS/rPbu9T9pxSHpgIOywz8MQCt8zVbhrfxCMLWM3N+b9TxDXayHSd6Ee/zWMvPFnb0RvW912tMg5R4t81lO7cNlgEeKF/Sq6SXr9+wLFv0mbumsI7eNV6dBYL5KCsMO0sgvI+z3IrK5a0IR6AdSCrPruJRZGjLyHrRc8x/Rn4rp8qOY1jVRC7mcWH8q3rxFfdalO0wPqbVpIacMmy+Pi6ylXtG8Rj8mkCW3SkVR93Z98nVz0JL4R1MFjVMghrmD+uFaGV/tibvaZfZPIuqs4jYeMbJBDenDF7bloE/4YH6683zEhXxPOnw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bq2riRRsWv8CzNne7c+nl8ELBbZkPP9279yn0ByKXQbnJQAXTvyT4vaxO3ee3kx5KKHdHlBTEeouKyCDUCRNseJb7W5WmCH5B/guX9xJi2jO9hfDna0Z145v9NAw2Dnt9CicvPnnnl3V8eKniYI/cmRRicPAF2GtlQfWBtFXbxAjXuxOw6X/uatHxugKF+4QZSgduBv7Tg/U6QTlDx06uTm2sxxpT60aY25jpe9STQ2P7B5Huq5slMQPFvlwfx4vq1PMIyRxAMQhnBq7n2R3teo2Xj1/VGyMw0dZ2jEZmB30fh4y6zgUZfdvvVEwESorxP7Dbxn1S3E1CLaapicK2Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 15 Feb 2022 16:19:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.02.2022 16:46, Oleksandr Andrushchenko wrote:
> Question: can anyone please explain why pcidevs is a recursive lock?
Well, assuming you did look at the change making it so, can you be a
little more specific with your question? Are you perhaps suggesting
the original reason has disappeared, and no new one has appeared? I'm
afraid I have to repeat what I did say before: If you want to remove
the recursive nature of the lock, then it is all on you to prove that
there's no code path where the lock is taken recursively. IOW even if
no-one knew of a reason, you'd still need to provide this proof.
Unless of course we'd all agree we're okay to take the risk; I don't
see us doing so, though.
Jan
|
