[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 14 Feb 2022 15:09:05 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T/Wg8UUDDKuFbkM3QvHxuum3jOuNYrYnWD02Zgbhh2Q=; b=cfqF/HffRnWKvSjlicM2G34VZogELXRbaHknhYF6Sm2on6DX+nfBU011Xgpp8C7rmEOoI53VE8rCbCn0v01FHM90Zl0EpoMhIuvqaGls70zEAQM97nCLcfnVp8/bgdBAtyvVIDe3hjxWLFKA1KoeUh0d+WmaMs00jqpzx7XTfA3Qna6HstShusjM4T4WYVvXSCsj1l2UjkUCNh2UDp41bnEOXlN8d6R5mAvo8CWu3xoTZxAtdngMA/uuH68Tk0eDpx1EQIKPPpOEiiI08UTOlyxhNobrAooP0qgwJQGkNzEnd4Q2o1sK8xRYj9gRjTBohYA5b6mkh75fvrfHFzSFFw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bGydpSGFt4JB8LW6TzCV8JisJx8r0JCSvGVCgs6aG0l+V/9r1T1R0O4oSMW5HAp0NmCnWXE5mhgq3gf4t5mLU4DP4E63EafIHhHqaiMde6Tv1AeaS367GPXir+xHq8Mw58ZxHT84yHadRtjvwA2Xf1kOXsaA+zCFmjazhTq3qABkD3MaXzIPrGSJs6l7vsWyjblWlG+WpFAYNXSSO+8Y0AuzCv3ch1KGP4SZU9YuxBVEJGLFIbTANDfBySQi0ZZ+QL37u8Qcw8TCtAQG2l92h0hZ+KsvwkqGc3vxfp6dky7RBcg8kcJeaXHVUbb0Cw0uakAaZEb5MfMtHtedKKUq9w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 14 Feb 2022 14:09:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.02.2022 15:00, Oleksandr Andrushchenko wrote:
> /*
> * FIXME: apply_map is called from dom0 specific init code when
> * system_state < SYS_STATE_active, so there is no race condition
> * possible between this code and vpci_process_pending. So, neither
> * vpci_process_pending may try to acquire the lock in read mode and
> * also destroy pdev->vpci in its error path nor pdev may be disposed yet.
> * This means that it is not required to check if the relevant pdev
> * still exists after re-acquiring the lock.
> */
I think I'm okay with this variant, pending me seeing it in context.
Jan
|
