Re: [PATCH CPU v1] cpuid: initialize cpuinfo with boot_cpu_data

[Norbert Manthey <nmanthey@xxxxxxxxx>]

On 2/11/22 11:34, Jan Beulich wrote:
> On 11.02.2022 08:23, Norbert Manthey wrote:
>> --- a/xen/arch/x86/cpuid.c
>> +++ b/xen/arch/x86/cpuid.c
>> @@ -609,7 +609,7 @@ void __init init_guest_cpuid(void)
>>  bool recheck_cpu_features(unsigned int cpu)
>>  {
>>      bool okay = true;
>> -    struct cpuinfo_x86 c;
>> +    struct cpuinfo_x86 c = boot_cpu_data;
>>      const struct cpuinfo_x86 *bsp = &boot_cpu_data;
>>      unsigned int i;
> While I agree with the need to initialize the local variable, I
> don't think it should be pre-seeded with previous indentification
> results: This could end up hiding bugs. Instead I'd see it simply
> be zero-filled.

That works for me as well, I'll send a rev-2 accordingly.

Norbert




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879