[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] x86emul: fix VPBLENDMW with mask and memory operand
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 11 Feb 2022 12:09:03 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vle0Ii9zLD/mplP4nqUmRUtRDq+Ksr5YXBw/LJA402c=; b=MhxObvdoQHngComXdIr7k385Xz0UZkllJD/OR3qIfGst5JmNxdc66OblwQmmogIS9MGauPPlvCVUYMqVNrY/ePKqlleFmGPnkikyJNKS2tWsT1UgQV93swX4xR0RkAy9dB+uL+uSJK3u4i4j/43MezoiZpp8fwkOONSS27Fo/pPKPs7hyaQ3TwMNQ04LIXinqWxgzIBq76oOVwy6NARMtrnV+hhHITuf74E1rou4nH4RKOAnUEs+dpKpSUOF8Ibng9iA2ZRxLbGER4+yxKxGCKQ3zVE9BjsMo7opaVcIP8fcfnrXLnf/iAczJYIFQpapo79zdOmnOH/SgUr1iwcc7w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k0881IkRPU9aYIcVnH6EiY50VIb/f4rW/QWoRZmMzp1uOELhYHbVKVQptdED9nv7RQnwA5UqnYqSGyNrUZ2kQ8P/3WRs1Gy1+XHkphGhkXkViPLgcG2QdSHBXvinIUAjRnLe/G1zqFdwa3sylA1IV7UbWERQ1ICLXekladAWux9+zeUCqotGG7fjPn/7EiCsaffasXgizr5AbE287sFaYN3HHX0VH/+hpejSLAg4Cz1amq4HVVPZiI9oSo6eaQ6t/8qIaTsdIOoYUTKjQb4TlR66Sis4M6+ovSe6PEaUaum5GWz+PUX9IZwmBqIx37C6nhwl760TRhf5gsHN4BU+0g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 11 Feb 2022 11:09:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Element size for this opcode depends on EVEX.W, not the low opcode bit.
Make use of AVX512BW being a prereq to AVX512_BITALG and move the case
label there, adding an AVX512BW feature check.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -7401,7 +7401,6 @@ x86_emulate(
case X86EMUL_OPC_EVEX_66(0x0f38, 0x0b): /* vpmulhrsw
[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */
case X86EMUL_OPC_EVEX_66(0x0f38, 0x1c): /* vpabsb [xyz]mm/mem,[xyz]mm{k} */
case X86EMUL_OPC_EVEX_66(0x0f38, 0x1d): /* vpabsw [xyz]mm/mem,[xyz]mm{k} */
- case X86EMUL_OPC_EVEX_66(0x0f38, 0x66): /* vpblendm{b,w}
[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */
host_and_vcpu_must_have(avx512bw);
generate_exception_if(evex.brs, EXC_UD);
elem_bytes = 1 << (b & 1);
@@ -9558,6 +9557,9 @@ x86_emulate(
/* fall through */
case X86EMUL_OPC_EVEX_66(0x0f38, 0x54): /* vpopcnt{b,w}
[xyz]mm/mem,[xyz]mm{k} */
host_and_vcpu_must_have(avx512_bitalg);
+ /* fall through */
+ case X86EMUL_OPC_EVEX_66(0x0f38, 0x66): /* vpblendm{b,w}
[xyz]mm/mem,[xyz]mm,[xyz]mm{k} */
+ host_and_vcpu_must_have(avx512bw);
generate_exception_if(evex.brs, EXC_UD);
elem_bytes = 1 << evex.w;
goto avx512f_no_sae;
|