[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 10/13] vpci/header: reset the command register when adding devices
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Thu, 10 Feb 2022 12:54:35 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OF319WDOBOLg7iDQ5tD/virkZ9tfy3+tlKy89nAktm0=; b=Xhbj+VCMCnwNJBId50idA53olbj+20gf6rxmx/DKLu92GwBp3+xqCJd5JyPXIV6sOxWD6Cbu0q8/w8sPVT2wyzCHyt5zb3xZ8xybO2+TPeLSPrx5OsaK1dYplsY/pZh57OClcsAt0RtX9z6hUYG8WmbMNWTcFj3hzq7a7IZ6CHcsNC1o84dOXnQgpgUpv8B1sIuHSvzderlgT16+PyphxeActQTqLe85KSc2xaNpJ67Fn+snsA/aN7ywje3p3MBD7jvnPbMLCGs6itJbGV2BQ/JdACA57nz2wIAHcgkNT7Mde0FP5N/Vz5vSL5ait7Dml/YTfKF9UEd546l0VJ7u0Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RgCwno5PLDIVXp5vwERR/x6fiRxNkZZ1/SKD6VZzDSAv9DI8oDsoO6pv3P4Hn8wEVGMDiBTNcLiAhv2W9/WzhaE4TBdNjUZJx5VhqhrS91CQIMeigucKjf+r7uU4/GEkMzv2OkLPev0/gebntVQnym1QpAQVdtGVUNYpXLJNR48V6LGlPcXwSUckDwuB7vop1nqnrGgxzqxaYifK78Gwy2rpOfJEmcun+acLCJoMqlDFvbZf38FiV4+HBeknsSKTkhYN5CaQIW5CfQlVRO5N3e+v8nQHTo5PlzgqK5sQT7+w9M7bVCZVJjlfE6LEFKm4deWVeTDuW4u4RLgrebxzhQ==
- Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Delivery-date: Thu, 10 Feb 2022 12:55:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYGZFg3nazYSvfA0G+yHTbxcxX2ayDdFgAgAAB6wCABD+NgIAAQmgAgAAT4YCAAAOjAIAAAPCAgAAXGICAAAPHAIAEnAeA
- Thread-topic: [PATCH v6 10/13] vpci/header: reset the command register when adding devices
On 07.02.22 16:31, Jan Beulich wrote:
> On 07.02.2022 15:17, Oleksandr Andrushchenko wrote:
> But: What's still missing here then is the separation of guest and host
> views. When we set INTx behind the guest's back, it shouldn't observe the
> bit set. Or is this meant to be another (big) TODO?
Why not? This seems to be when a guest tries to both enable MSI/MSI-X
and INTx which is a wrong combination. Let's pretend to be a really
smart PCI device which partially rejects such PCI_COMMAND write,
so guest still sees the register consistent wrt INTx bit. Namely it remains
set.
>
> Jan
>
>
|
