[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] block: xen: use time_after_eq() instead of jiffies judgment


  • To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
  • From: Qing Wang <wangqing@xxxxxxxx>
  • Date: Thu, 10 Feb 2022 00:29:23 -0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vMLJbdOpfHG63MP8VB14fg4rzHqLyuvfrpbIjSDncH8=; b=h4tyTpJGmQ1eRcdcSb/RDwf8pOBkEiJfkOJqYc9k2VlNltjtugwx4JbFm3uaLOMubCrYwKdCm+wv9Yt8uyIXcjoa9mgD9iPwGT+uIRF45PBW0loPz769CcfQQYnrz2RXa2wW/j6/xq2Wxio3Nwy4KweOwzFqabF68SsIjVzVWTrAXX+HbkWSXt+jpyWFuGHkZXMTl56q/FwCAVGmwSy0n/cNZF75gwx99CkJwF2NiNtu8ZvLeXuDr+obIg3zMDC40wjcaYBZNvVYliPxUByBZ0XF39C4iEhXLkxEiBL+ZtIZkxV7lrJ5TDHV07tWIkzMplHJmN/qSLX228kv4Tg0/g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OV3YHnXHBZ9UtqzcjCgQCWg70dU95Am2kfUYz8vBlifcarW/JGeyye7wFCcW6Z2nZvlhJ3Qc0np/5tty68+yUdIDrwGtwiKi07C+yqqHzyY+mM/0pVjNQjFe+O3KRpTFmtHR6p/pFHfqMHnuesFaMnHIGYxKsM+AnsoTLXahMT92uCtKXtqZxFIJRBbjO9Hi8k481IkFSHaOsTaINiZ6Pp5rF43z9+zxfBGxC+OqxOh8keG0AjNJphTDpNZmBJ0hQU554QgK50VyCos3nXyasACKLJELUgun/o77Qvxs+Cq6zr38h1MM9gjAhIWPooWFOfPeKOlD3/0+I2P3wPo6wA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com;
  • Cc: Wang Qing <wangqing@xxxxxxxx>
  • Delivery-date: Thu, 10 Feb 2022 08:32:17 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

From: Wang Qing <wangqing@xxxxxxxx>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@xxxxxxxx>
---
 drivers/block/xen-blkback/blkback.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/block/xen-blkback/blkback.c 
b/drivers/block/xen-blkback/blkback.c
index d1e2646..aecc1f4
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -42,6 +42,7 @@
 #include <linux/delay.h>
 #include <linux/freezer.h>
 #include <linux/bitmap.h>
+#include <linux/jiffies.h>
 
 #include <xen/events.h>
 #include <xen/page.h>
@@ -134,8 +135,8 @@ module_param(log_stats, int, 0644);
 
 static inline bool persistent_gnt_timeout(struct persistent_gnt 
*persistent_gnt)
 {
-       return pgrant_timeout && (jiffies - persistent_gnt->last_used >=
-                       HZ * pgrant_timeout);
+       return pgrant_timeout &&
+                       time_after_eq(jiffies, persistent_gnt->last_used + HZ * 
pgrant_timeout);
 }
 
 #define vaddr(page) ((unsigned long)pfn_to_kaddr(page_to_pfn(page)))
-- 
2.7.4




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.