[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86


  • To: Anthony Perard <anthony.perard@xxxxxxxxxx>
  • From: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
  • Date: Wed, 9 Feb 2022 15:28:31 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bpg2I5WKFBKETW7gLBy9FPk34HZxeoYvF70yHK+WfW0=; b=hOrETNs0oUmDxmT5WBD/2CLihrZxgRkoXCJUvnFr+iz5hWnAE8kDCM2dAl+8MyT5CQ7IEIKZmgK4A8J11GKBKjRwq7AdlKjbeF85kVempTJ1D1WRkmT2RiQxkDiREnqAF0jcrvz26J0lIsLW62B1iaPKfu6F6poGULfhyuysTa4IkbFSmX3t6D+i4hhQymdV0qFwiSweWaHtIfKBoj5tlUqjzYCXliy/+fU9V8o8UGWyu4+cAL2TqgBqBwSP9QOz5galjHRzetM208da7HSQLm3c2eaAuuc9i/ITxIyBNWM+CLmPwdbs5OdkF4pBmDUZt3rGaNrxVVu+U6ruDf5cDg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hQ1v+TfY2S8Co6pk/Dz5MVVO8G9BB3io3eWcipubPLqjCgP4LXrfWy2ykxuH8YHwS0X6FYluLOBB1BZUZkoChCm9QKlR/k/S86JbnYtwYZsnBzA4rD/ZkTkWKIXDv7rgMVJPHqt+VOaUlI14ntf/JNVvtxdus37Vi1vx3nItBCUexVtd4ZkAWU7DJKnDlX1o8dLJcgtZ/ibREf3DdYfCVW8Z/fDA1fHKMITH9Hro+YROSrBtaBB9GdrrxXWvMNrwrVWX183xPhIb2yvqEUxcc8/fc09sedV5fZoRKAA0s1oE0IvX2CrNZlTPG/t5msNJvax74iBJ6VaHM0eULke1DA==
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>
  • Delivery-date: Wed, 09 Feb 2022 15:28:55 +0000
  • Ironport-data: A9a23:Ll/hQq6xqCcCvJT+VqcK8AxRtDnBchMFZxGqfqrLsTDasY5as4F+v moXDGzUPPreN2TycopybIvgoxwO757Wx99iSQdopH00Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2t8w27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zw d9f7ZWBCiASJqTPuNsiXkdfGhhaMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALDsDtMcU6s3VpyTjfAN4tQIzZQrWM7thdtNs1rp4VQqqOO 5tAAdZpRBjyeEFUPX4NMZ0BreiUh1faLWNgjmvA8MLb5ECMlVcsgdABKuH9RNuOQslEm1eCk UjP9W/5HxIyOcSWzHyO9XfErvTUgSrxVYYWFbu53v1nmluewioUEhJ+fVG2u+Wjg0iyHddWM VUJ+zEGpLI3skesS7HVXBCmoXjCoh8VXfJRFfE37EeGza+8ywSEAC4CRz1Iat0jvec3QyAn0 hmCmNaBLSNrmK2YTzSa7Lj8hSO/P20ZIHEPYQcATBAZ+J/zrYcrlBXNQ91/VqmvgbXdGz7qx CuRhDMjnLhVhskOv4254FTGjjSEtpXPCAkv6W3/XGio8wd4b46NfJGz5B7Q6vMoEWqCZgDf5 j5ewZHYtb1QS8HW/MCQfAkTNLij9a6MAX77ukZmHLkeyDnz/HeaWY8FtVmSO3xVGsoDfDboZ mratgVQ+IJfMROWUENnX26iI590lPa9TLwJQtiRN4MTOcYpKGdr6QkzPRb44oz7rKQ7fUjT0 7+/eN3kM3sVAL8PINGeF7ZEiu9DKszTKAruqXHHI/aPjOP2iJ29E+5t3L6yggYRtv7sTOL9q Yk3Cidy408DONASmwGOmWLpEXgELGIgGbf9oNFNe+iIL2JOQT99V6SNnO9wItw8wsy5c9skG FnnBye0L3Kl2hX6xfiiMCg/ONsDo74jxZ7EAcDcFQnxgCVyCWpexKwea4E2bdEaGB9LlpZJo w0+U5zYWJxnE22fkxxENMWVhNEyJXyD2FPVVwL4MWdXV8A7HWThpIS7FjYDAQFTV0JbQ+Nl+ Ob+vu4aKLJeLzlf4DH+Mqrwlgjs5ihEw4qfnSLge7FuRakly6AzQwTZhf4rOcAcbxLFwzqRz QGNBhkE4+LKpucIHBPh3Mhodq+lTLlzGFR0BW7e4erkPCXW5DP7k4RBTPyJbXbWU2atoPeuY uBczvfdNvwbnQkV79ogQugzla9utcHyo7J6zxh/GCmZZVqcFb49cGKN2tNCt/MRy+YB6xe2Q E+G5vJTJa6NZJH+CFcUKQd8NraD2PgYlyP89/MwJEmmtiZ78KDeCRdZPgWWiTwbJ7xwadt3z eAksc8Qygq+lht1bYrW0nEKrzyBdyVSXb8mu5cWBJ7QpjAqklwSM4bBDiLW4Y2Ub4keOEcdP TLJ1rHJgK5RxxSefiNrR2TNx+dUmb8HpAtOkA0ZP12Ml9fI2q030RlW/WhlRwhZ1Ewaged6O 2wtPExpP6SeuTxvgZEbDWyrHghAAjyf+1DwlARVxDGIERHwWzyfNnA5NMaM4FsdojBVcTVs9 b2FzHroDGTxd8br0ypuAUNoppQPlzCqGtEuTCx/I/m4Ig==
  • Ironport-hdrordr: A9a23:7oP7i69FJ5eiVGA80ltuk+F7db1zdoMgy1knxilNoENuHfBwxv rDoB1E73LJYW4qKQwdcdDpAtjkfZtFnaQFr7X5To3SIDUO31HYbb2KjLGSjAEIfheRygcz79 YYT0ETMqySMbE+t7eB3ODaKadh/DDkytHRuQ629R4EJmsKC52IrT0JcTpzencGHjWubqBJcK Z0k/A3wQZIDk5nCfhTaEN1PdTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx mHryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczBgNl1mpDr1L8Zqq iKn/4SBbU015oXRBDtnfLZ4Xil7N/p0Q679bbXuwq5nSWzfkNENyMIv/MmTvKe0Tt8gDg06t M740uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pVVFb/l/1rwKp5KuZJIMvB0vFtLA CuNrCp2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZNyLstD51fo+ jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR52Mi6PJgTiJcikp XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NFAgFCvsukaSRloeMN4YDABfzP2zGyfHQ08n3KverKc qOBA==
  • Ironport-sdr: KBMBpYGSxZBT2Ttm762+7Skl+dxS+BZ0i+8nzukQ1Gr2pPYFI2/7vna5/cqH4Y1+3NdCjazZGK Ax6fxKM8Z+oViuZkwd53/CQ5C2KIr3d1rPZd1H8q68HWSYy/7naPoFSVcHsX4Ns1baBB7r4SZO 8fb+hQAsFtrD5xt3F76i4g8n0lIHCODm6cbfsYW5XwdUG7zLSzevgv1+KHLpKJVKoPyauRMFED CY6YVMxFGHaVdF/0KswfRBKTM2UolqhBjY37krII6PWAZt8Sh6+Dvhb81hf0BGhZTrjkSX5gMI r4rQM+UHH9V0S4MjrNTakpmk
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYHE+TdJl64aH33EedeR0PZ4zblKyJx9wAgAFf6oCAABb6gIAAHAAA
  • Thread-topic: [PATCH v2 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

On 09/02/2022 13:48, Anthony PERARD wrote:
> On Wed, Feb 09, 2022 at 12:26:05PM +0000, Jane Malalane wrote:
>> On 08/02/2022 15:26, Roger Pau Monné wrote:
>>> On Mon, Feb 07, 2022 at 06:21:00PM +0000, Jane Malalane wrote:
>>>> diff --git a/tools/golang/xenlight/types.gen.go 
>>>> b/tools/golang/xenlight/types.gen.go
>>>> index b1e84d5258..5f384b767c 100644
>>>> --- a/tools/golang/xenlight/types.gen.go
>>>> +++ b/tools/golang/xenlight/types.gen.go
>>>> @@ -389,6 +389,10 @@ RunHotplugScripts Defbool
>>>>    DriverDomain Defbool
>>>>    Passthrough Passthrough
>>>>    XendSuspendEvtchnCompat Defbool
>>>> +ArchX86 struct {
>>>> +AssistedXapic Defbool
>>>> +AssistedX2Apic Defbool
>>>
>>> Don't you need some indentation here?
>> I hadn't realized it appeared like this here (and the same happens for
>> other parts of my code as I'm seeing now) because the git output is
>> correct. I will fix it.
>>>
>>> Also name would better be Assistedx{2}APIC IMO if possible. Having a
>>> capital 'X' and lowercase 'apic' looks really strange.
>> Okay.
> 
> 
> This is a generated file, you can't change indentation or fields names.
> It would be rebuilt automatically if you had golang installed and where
> rebuilding all the tools.
> 
> There's two ways to generate it, you could install golang and build all
> the tools. Or without golang: just
> `cd tools/golang/xenlight; make types.gen.go`. Both should regenerate
> both "helpers.gen.go" "types.gen.go" files.
> 
> There's an even easier way, tell the committer to regen the files when
> committing :-).

Oh, yeah I forgot they were automatically generated. Right, thank you.

Jane.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.