[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 2/8] libs: libxenhypfs - handle blob properties
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Wed, 9 Feb 2022 14:04:25 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fcucRsHBZMhsJaoRK7TEghykSWrfqtMf4Qvq3TJUhfk=; b=BKrgvD2f58z3zC0etRvui9/QtxYArIsVi/svz1JJcJO2fFQ1TlS+fFQ/g/+xHzJRuzfDpDsheZbPk71+EcKgQms+IH445AfuUifUXgVDgXShlTrAar5zLGkV2nHtUWJXVU7Q3BQ982nHuXOpupzk9aiy9Yoe8ydMS2nWLRChuLSLAQZhPaA5Ch54zKIc4FdAMzmRKIvSAyfNgSjb9ymCMTAVJzJaLavwTTx0JRN/oImIstBFHrwos857r/1C8rpLykHHhtBLmOLoQu2Y9kHQsvCcJlVPEur/aTcviLPYQaQt/dxKDsOMkNuGN4cGwlIFfz1GRHp4DEOMPssFSzLUnw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YY8YcwTxwWOryLgY89NigYJuhWN2eUvFlozRY3ZcxiZnvoVpTy2ZAluiIXsdQBQpLiTBypvjRM6y951G9urOg0BU1UciQWZ0TZyBsjEUo+ADK1llDkI/Gy2GK/PRYePIT5SyO+5YR306Y3gmJzbdVoSrSSiZ2O/GKL1z0N1tVUEMFm5PvJUw1GZqEFtcYURmbyVxCxiXCya0hIK0v6u8EIXLgHynfieHsVwV8W3GMRlNm1co96h1pxvJdEgJ6LdFjXGMjvLVqh2ZHIkYYsUMiTST0skkEqXWYcqUhZvnGf8ZBtCsQ8zw9ZBtPwvp7x1IWHTrOA5cZ0Cej8dcwaWLbA==
- Cc: Juergen Gross <jgross@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 09 Feb 2022 14:04:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYHbudSLxWMD9F30i+VGpqKP0vfqyLP4KAgAAA6oA=
- Thread-topic: [RFC v2 2/8] libs: libxenhypfs - handle blob properties
On 09.02.22 16:01, Jan Beulich wrote:
> On 09.02.2022 14:47, Oleksandr Andrushchenko wrote:
>> Hi, Oleksii!
>>
>> On 08.02.22 20:00, Oleksii Moisieiev wrote:
>>> libxenhypfs will return blob properties as is. This output can be used
>>> to retrieve information from the hypfs. Caller is responsible for
>>> parsing property value.
>>>
>>> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx>
>>> ---
>>> tools/libs/hypfs/core.c | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c
>>> index 52b30db8d7..d09bba7d8c 100644
>>> --- a/tools/libs/hypfs/core.c
>>> +++ b/tools/libs/hypfs/core.c
>>> @@ -307,8 +307,6 @@ char *xenhypfs_read(xenhypfs_handle *fshdl, const char
>>> *path)
>>> errno = EISDIR;
>>> break;
>>> case xenhypfs_type_blob:
>>> - errno = EDOM;
>>> - break;
>> This will need a /* fallthrough */ I guess
> Why? There's no statement left before the next case label.
You are right, no need
Sorry
>
> Jan
>
>>> case xenhypfs_type_string:
>>> ret_buf = buf;
>>> buf = NULL;
>
|
