|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [PATCH v2] xen/public: add comment to struct xen_mem_acquire_resource
Commit 7c7f7e8fba01 changed xen/include/public/memory.h in an incompatible
way. Unfortunately the changed parts were already in use in the Linux
kernel, so an update of the header in the kernel would result in a build
breakage.
As the change of above commit was in a section originally meant to be not
stable, it was the usage in the kernel which was wrong.
Add a comment to the modified struct for not reusing the now removed bit,
in order to avoid kernels using it stumbling over a possible new meaning
of the bit.
In case the kernel is updating to a new version of the header, the wrong
use case must be removed first.
Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
---
V2:
- only add comment instead of reverting commit 7c7f7e8fba01 (Jan Beulich)
---
xen/include/public/memory.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
index 383a9468c3..86513057f7 100644
--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -662,6 +662,11 @@ struct xen_mem_acquire_resource {
* two calls.
*/
uint32_t nr_frames;
+ /*
+ * Padding field, must be zero on input.
+ * The lowest bit was named XENMEM_rsrc_acq_caller_owned in a previous
+ * version and should not be reused in future.
+ */
uint32_t pad;
/*
* IN - the index of the initial frame to be mapped. This parameter
--
2.34.1
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |