[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 4 Feb 2022 09:36:38 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1TotICqAwwNoNsvdJSgFi+8lkACU119xtP8l1WMdwUo=; b=g8x7Fyg9/AYGvFda/UYy2UDl56ssC0NoVcBE4+mlNqz+for2SgOPLNTga6ZQ5qNnRuWkzQSgGGbTO84Ox/nXKymVwwoQfLyy9juKRhdOdfn5D0hRYPKt6azPQlejfPT1Tqgyo7igErxKd+IIXpb3nNABYJbgQoLTLujCjqCnWCaxsa7XuXq0XCF/mPsL6XXnPbX4sSM6pZDsbFZKDLsVTkFxos7kzHCeMjZeztUFVbCzzNZxDJ2TQDVAOs59hYzSNL+MuARH1hEShL4eVDuYIbFS54u/XNHYWqh8bzCZ5JHc/Hgoo4KZMpLKlEEoqG4/h7NJ3ZP4Vh9HeLi1/2Kcqw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BYM9sj1MfqqPX2t5+G230vI8Ljnuy2cdkthCHc5ukLbaDun/cbaq5ZIMFhgLgCH6NNVAfDQHbCU6ClMTYqJ/1ceYoeSySnBDnDOUKgVqY3qLRlAij+q4EB3h1k6vXZWAsfAtwi8iDZNTyuNk0qXso1o6TFO91HvT2I1ABwFTVny6lJwTsh6lNma/kxlLhPC0OwnMMtiGps84GZda4W5jgVPAjT219h6IT96Ci/Q5SRISHkSyLGlHVQXiPg7ei1VSlXdK9HkUoCTGZrPfVTtcEcp7lC/gEpvDyRaVbMTdwNYylHU0BTowqdqo/d51IDRw5R8wkTyAvuhJCHbhKHpnxQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 04 Feb 2022 08:36:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.02.2022 09:13, Oleksandr Andrushchenko wrote:
> On 04.02.22 09:52, Jan Beulich wrote:
>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>
>> At the first glance this simply looks like another unjustified (in the
>> description) change, as you're not converting anything here but you
>> actually add locking (and I realize this was there before, so I'm sorry
>> for not pointing this out earlier). But then I wonder whether you
>> actually tested this
> This is already stated in the cover letter that I have tested two x86
> configurations and tested that on Arm.......
Okay, I'm sorry then. But could you then please point out where I'm
wrong with my analysis?
Jan
|
