[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/2] x86/mm: tidy XENMEM_{get,set}_pod_target handling


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 2 Feb 2022 16:14:46 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3JtSTh7t3cVGnSGxaJCada0ZD+PemwdU4u58v5gELL0=; b=ezEr15apGXiUcy3QKMfBqoMzSxvGINzmhVpOMUptLpwiiIpVfo70ocGJper2tZF3lEe2wwEWRs4XY7TTdSak8UEGgObUwuXyR7rPREtwLaAZMwad4bWw+uPpEdLp2CvNkg+2lYDg3P7e4D1Trnk0FsqZzlxj6OEAmmSu9yLPc7OOpBe6MDm6H7v2pzFabjO+wekiFnlWALWdWT7p5pFZIQ9LuHqNwyMMd3qmnHYUxrqCegTxw1mkWkH4bFE4IrvqeuWbUhoJK9W+BOkYJ9IHClItxoL63q4SBQU/M8trnfqsu7tsMIXXDZt4aaiEJLpIaD7W6DyMCsJ7YiDpIrFzCg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R+DMPe/VPiUR3obl3B3XVpjVY64uhO8IVK/Q9LLOrtIgIurcoR3hRpGfDvcWMhWbPhMTM7IUTK5p/ocYMOnTBwjS5tQtrhduWd1970U/6Ll9UhNE9b1Ysg8VuAxEWN6sRUypj/5mdasYlW2Hu6Lu/zT1mwwNbKWURtmiTWuRMqZAoCxdcW6sYCwL/kePuMaP+XmEqVDJi/HtEZ+vjR4zyPbqNg/KG/70T6f22bACDtEw9WpsI0KKT5SAs6wxOtZW2xEJmcIn8pSMXxTZIjIP4Nwc1o9jj3HoakfkTjyYIrZTpFoyam1A5tZTUILaOv8oo6D2dGcX9FC0B6mv9YQZug==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
  • Delivery-date: Wed, 02 Feb 2022 15:15:03 +0000
  • Ironport-data: A9a23:nuvooaBRbnp0OhVW//Tkw5YqxClBgxIJ4kV8jS/XYbTApGgihj0Px mMXUGuCbqqKM2L3fot3bYW09kMDvpHdndY3QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970Ug7wYbVv6Yz6TSHK1LV0 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/timPsdtwl 8505LeQTF0xY7fTt+E9akwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHf6RvoQEhWdYasZmLaz6T uxJYCFUTw3tYx9LY1MJS5wStbL97pX4W2IB8w/EzUYt2EDMyCRh3b6rN8DaEvSaSMMQkkuGq 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTcIAYGaC89/VqqEaO3WFVAxoTPWZXutHg1BT4AYgGb RVJpGx+9sDe6XBHUPHAQxuWq3/bpSdNcPpVSfVn8h6iz4rttlPx6nc/chZNb9kvtckTTDMs1 0OUk96BOQGDoIF5WlrGqO7K8Gra1Tw9aDZbOHRaFVdtD8zL/dlr5i8jWOqPB0JcYjfdPTjri w6HoyEl71n4pZ5ajv7rlbwrbt/Fm3QocuLXzlmGNo5GxlkgDGJAW2BPwQODhcus1K7DEjG8U IEswqByFtwmA5CXjzCqS+4QBryv7PvtGGSC3QUwQ8Bwpmn0pS7LkWVsDNZWfx8BDyr5UWWxP B+7Vf15uPe/w0dGnYcoOtnsWqzGPIDrFMj/V+C8Uza9SsMZSeNzxwk3PRT49zm0yCAEyPhjU b/GL5rEJStEWMxPkWrnL89AgORD7n1vmgvuqWXTkk7PPUy2PiDFEN/o8TKmM4gE0U9ziF6Er o8CZ5bWkEg3vS+XSnC/zLP/5GsidBATLZv3t9ZWZqiEJA9nE3smEPjf3fUqfIkNokifvr2Ql p1kckMHmlf5m1PdLgCGNiJqZL/1BM4tpnMnJy08e12v3iF7M4qo6a4ecboxfKUmq7M/naIlE aFddpXSGOlLRxTG5y8ZMcv3ort9eUn5ngmJJSekPmQyJsYyWwzT99b4VQLz7y1SXDGvvM4zr uT4hAPWSJYOXSp4C8PSZK79xl+9pyFFyulzQ1HJMp9Yf0C1qNpmLCn4j/kWJcAQKEqcmmvGh ljOWRpB/LvDuY449tXNlJuolYbxHrssBFdeEkna8a2yaXvQ8F28zNISS+2PZz3cCj/5of3we eVPwvjgG/Qbh1IW4ZFkGrNmwK9itdvio7hWklZtEHnRNgn5D7phJj+N3NVVt70Lzbhc4FPkV kWK89hcGLOIJMK6TwJBeFt7NryOhaMOhz3fzfUpO0GrtiZ48Y2OXVhWIxTR2jdWK6F4Md99z Oos0CLMB9dTVvb+3g66sx1p
  • Ironport-hdrordr: A9a23:8BPSd63wMyLhm+szph5YRgqjBVByeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79 YcT0EcMqyPMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt5dBmxCe2Cm+yNNNW177c1TLu vh2iMLnUvpRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIE/Z4StU z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF/nMifrHIR1P XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvmOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1qop5PzuN5d3B+3Z W1Dk1frsA6ciYnV9MNOA4/e7rFNoXse2O7DIvAGyWvKEk4U0i92aIfpo9FoN2XRA==
  • Ironport-sdr: pXzJWqyKZr+9btlBIQKiCgtLHrP5nA6RNQ6LmBipJSIXM+B3/N9l6A3gmkfQnhRsQvJ4EeGeIR FHyHgz+PIJ9u2N1XQombOsdWePP4/RRS7UoF/8uj5wiYKYkj+U/G2jIdHi1+Er4PTvlxz97qGk gGvqqjpdEYRNKLBPC33q888AdeRMsbTsJjeLu6GB5OsyzuJGgS2N/fPTaed4kJ7tc9HkMw+G20 F2xAdpwNf+/T8Ebm3bU9HSo/1vnjxOKAhzxazk+2Mbj/g3Qu6YyOd2TQt2PFNmG/3nufFxrsJy 9LX53Z3iHq443NV9ckQEgLWC
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jan 04, 2022 at 10:41:53AM +0100, Jan Beulich wrote:
> Do away with the "pod_target_out_unlock" label. In particular by folding
> if()-s, the logic can be expressed with less code (and no goto-s) this
> way.
> 
> Limit scope of "p2m", constifying it at the same time.

Is this stale? I cannot find any reference to a p2m variable in the
chunks below.

> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Code LGTM, but commit message likely needs dropping of that last
sentence or the block using p2m needs to be adjusted.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.