Re: [PATCH v5 06/14] vpci/header: implement guest BAR register handlers

[Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>]

>>> I wonder whether we need to protect the added code with
>>> CONFIG_HAS_VPCI_GUEST_SUPPORT, this would effectively be dead code
>>> otherwise. Long term I don't think we wish to differentiate between
>>> dom0 and domU vPCI support at build time, so I'm unsure whether it's
>>> helpful to pollute the code with CONFIG_HAS_VPCI_GUEST_SUPPORT when
>>> the plan is to remove those long term.
>> I would have it without CONFIG_HAS_VPCI_GUEST_SUPPORT if you
>> don't mind
> Well, I guess if it's not too intrusive it's fine to add the defines,
> removing them afterwards should be easy.
It is intrusive: it is easy to add such a define in struct vpci, but then you 
need
ifdefery in xen/drivers/vpci/header.c to sort out the case when it is defined or
not. I can still do that if you insist
>
> Thanks, Roger.
Thank you,
Oleksandr