[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/serial: scif: add support for HSCIF


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>
  • From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Date: Thu, 27 Jan 2022 17:18:52 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9kT+KpM4dXYi6LOx5cIQab4cJkY5Y7hJY7aMajLxK1Q=; b=Nw0ARgZpLWMgQ1SqlIi/jXvvnLGx+6fX7mEOKv6mGR2ImimWWyOX9m5W9NvbjXEuZdhQfFnhsYHTh5zBHOxzJ1fa8/fZkqXW/U1aPZQAaVTUxm1hh1Ka4Bg8i2m5eWoUU72rU/XeSrNH4hVwYCD5qNzgiC1J9cLJqS5szCKq4DqrPnREaX6oBV8h2bRKxZWk5abPeqSNHkVCYe7FQ8uGOvvEv3cvT5HhvXA38V4u/l47BcTibJogMjGwvt+t1qTcPfxTmALdfO5XVOZULemgTNmooPY64KCG1hwJggtWTh5MoqVzzIHydhNUG3gCTdG5p3RufHZv3zRQhlmxntKy7A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZnoF9JZr0q+iPbQTjj7pYIDTovIFaNklEEiVLHtMMJ9XYH24NRywqp5sqM+dEFNs/TrKb5qdTxZlwO6dklL4fWQl98oux24r3HJ10JWrKlAuuD+WQ+KSrNfXtAOdZ6DSRhbaM5n7ifQ1Xp+L7Rfxjr7u/e0ZrQdXxXs1xPWThXllfv7jXItcPM8Cc5n17uixecS1itphY1+PbDXd8976q5lf7R47n1iE5XwYvi/Eh0WACXXp5k7wPXYAFJLoPEqREXYrf33aEJCnGiXZjqWNSjMLJIs7f5awsLEBEvfBLsI11jyAiLS6O3oylGvH3jsP0DB0MIdkOJq7wwqfNiVytA==
  • Cc: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Thu, 27 Jan 2022 17:19:13 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYE59f1kOdWDtKEkSxzzo4QkJiKqx3HBKA
  • Thread-topic: [PATCH] xen/serial: scif: add support for HSCIF

Hi Julien, Bertrand,

Sorry, I messed up with your e-mail addresses in the previous
email. Adding you correctly. 

Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx> writes:

> HSCIF is a high-speed variant of Renesas SCIF serial interface. From
> Xen point of view, they almost the same, only difference is in FIFO
> size.
>
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> ---
>  xen/drivers/char/scif-uart.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c
> index ee204a11a4..8f4485bdfc 100644
> --- a/xen/drivers/char/scif-uart.c
> +++ b/xen/drivers/char/scif-uart.c
> @@ -47,6 +47,7 @@ enum port_types
>  {
>      SCIF_PORT,
>      SCIFA_PORT,
> +    HSCIF_PORT,
>      NR_PORTS,
>  };
>  
> @@ -88,6 +89,17 @@ static const struct port_params port_params[NR_PORTS] =
>                          SCASCR_BRIE,
>          .fifo_size    = 64,
>      },
> +    [HSCIF_PORT] =
> +    {
> +        .status_reg   = SCIF_SCFSR,
> +        .tx_fifo_reg  = SCIF_SCFTDR,
> +        .rx_fifo_reg  = SCIF_SCFRDR,
> +        .overrun_reg  = SCIF_SCLSR,
> +        .overrun_mask = SCLSR_ORER,
> +        .error_mask   = SCFSR_PER | SCFSR_FER | SCFSR_BRK | SCFSR_ER,
> +        .irq_flags    = SCSCR_RIE | SCSCR_TIE | SCSCR_REIE,
> +        .fifo_size    = 128,
> +    },
>  };
>  
>  static void scif_uart_interrupt(int irq, void *data, struct cpu_user_regs 
> *regs)
> @@ -288,6 +300,7 @@ static const struct dt_device_match scif_uart_dt_match[] 
> __initconst =
>  {
>      { .compatible = "renesas,scif",  .data = &port_params[SCIF_PORT] },
>      { .compatible = "renesas,scifa", .data = &port_params[SCIFA_PORT] },
> +    { .compatible = "renesas,hscif", .data = &port_params[HSCIF_PORT] },
>      { /* sentinel */ },
>  };


-- 
Volodymyr Babchuk at EPAM


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.