RE: [PATCH 16/37] xen/x86: export srat_bad to external

[Wei Chen <Wei.Chen@xxxxxxx>]

Hi Jan,

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年1月27日 16:37
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
> Subject: Re: [PATCH 16/37] xen/x86: export srat_bad to external
> 
> On 27.01.2022 09:35, Wei Chen wrote:
> > Hi Jan,
> >
> >> -----Original Message-----
> >> From: Jan Beulich <jbeulich@xxxxxxxx>
> >> Sent: 2022年1月25日 18:22
> >> To: Wei Chen <Wei.Chen@xxxxxxx>
> >> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> >> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
> >> Subject: Re: [PATCH 16/37] xen/x86: export srat_bad to external
> >>
> >> On 23.09.2021 14:02, Wei Chen wrote:
> >>> srat_bad is used when NUMA initialization code scan SRAT failed.
> >>> It will turn fw_numa to disabled status. Its implementation depends
> >>> on NUMA implementation. We want every NUMA implementation to provide
> >>> this function for common initialization code.
> >>>
> >>> In this patch, we export srat_bad to external. This will allow to
> >>> have the code mostly common.
> >>
> >> Here as well as in the subject it would help if the function name
> >> wasn't the wrong way round. I also don't see how you mean to use a
> >> function containing "srat" in its name from non-ACPI code.
> >>
> >> Perhaps alongside numa_mode() (see the reply to the earlier patch)
> >> you want to have a set_numa_off() helper (name subject to
> >> improvement)?
> >>
> >
> > Yes, actually, I want a function to disable the numa when we encounter
> > any error in numa initialization. And we also so want to indicate the
> > numa off is caused by configuration error. So we had thought to use
> > numa_fw_fault to replace srat_bad.
> 
> Why not simply numa_bad() or, say, numa_disable()?
> 

numa_bad would be OK.

> Jan